Bugzilla – Attachment 151076 Details for
Bug 33421
Filtering purchase suggestions by status does not work if All Libraries is selected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33421: Fix filtering suggestions by status
Bug-33421-Fix-filtering-suggestions-by-status.patch (text/plain), 1.31 KB, created by
Emily Lamancusa (emlam)
on 2023-05-11 13:03:39 UTC
(
hide
)
Description:
Bug 33421: Fix filtering suggestions by status
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2023-05-11 13:03:39 UTC
Size:
1.31 KB
patch
obsolete
>From c1009217f2b4ddb7e82c4624051ff11bafcaf72d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 10 May 2023 12:19:13 +0200 >Subject: [PATCH] Bug 33421: Fix filtering suggestions by status > >If the display is by status and a specific status is selected in the >filter, the filter won't have any effects. > >Test plan: >Create several suggestions, with different status, for different >libraries. >Use the "display by status" view and filter on a given status >=> Result must be relevant > >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > suggestion/suggestion.pl | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index f85b4366ea..44fc5527d2 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -376,6 +376,12 @@ if ($op=~/else/) { > my @allsuggestions; > foreach my $criteriumvalue ( @criteria_dv ) { > my $search_params = {%$suggestion_ref}; >+ >+ next >+ if $search_params->{STATUS} >+ && $displayby eq 'STATUS' >+ && $criteriumvalue ne $search_params->{STATUS}; >+ > # By default, display suggestions from current working branch > my $definedvalue = defined $$suggestion_ref{$displayby} && $$suggestion_ref{$displayby} ne ""; > >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33421
:
150959
|
151076
|
151338