Bugzilla – Attachment 151113 Details for
Bug 33702
Patrons should only see their own ILLs in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33702: (QA follow-up) Do not crash on borrowernumber
Bug-33702-QA-follow-up-Do-not-crash-on-borrowernum.patch (text/plain), 1.21 KB, created by
Marcel de Rooy
on 2023-05-12 07:04:05 UTC
(
hide
)
Description:
Bug 33702: (QA follow-up) Do not crash on borrowernumber
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-05-12 07:04:05 UTC
Size:
1.21 KB
patch
obsolete
>From 9c747bbc389a99024b6d662f76f3ba3ab325be72 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 12 May 2023 06:56:07 +0000 >Subject: [PATCH] Bug 33702: (QA follow-up) Do not crash on borrowernumber >Content-Type: text/plain; charset=utf-8 > >Resolve: >Can't call method "borrowernumber" on an undefined value at /usr/share/koha/opac/opac-illrequests.pl line 66 > >Test plan: >Put an unexisting illrequest_id in the URL parameter. >You should see a 404, not a crash. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > opac/opac-illrequests.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/opac/opac-illrequests.pl b/opac/opac-illrequests.pl >index c97f32b47a..d239126d46 100755 >--- a/opac/opac-illrequests.pl >+++ b/opac/opac-illrequests.pl >@@ -63,7 +63,7 @@ my ( $illrequest_id, $request ); > if ( $illrequest_id = $params->{illrequest_id} ) { > $request = Koha::Illrequests->find($illrequest_id); > # Make sure the request belongs to the logged in user >- unless ( $request->borrowernumber == $loggedinuser ) { >+ if( !$request || $request->borrowernumber != $loggedinuser ) { > print $query->redirect("/cgi-bin/koha/errors/404.pl"); > exit; > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33702
:
150892
|
150923
|
150924
|
150939
|
151111
|
151112
| 151113