Attachment 151118 Details for Bug 33223 – Bug 33223: Fix sendshelf

[patch] Bug 33223: Fix sendshelf

Bug-33223-Fix-sendshelf.patch (text/plain), 1.66 KB, created by Marcel de Rooy on 2023-05-12 07:42:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-05-12 07:42:48 UTC

Size: 1.66 KB

patch

obsolete

>From dd48dc60fb633cabf4cb673e919b9e85207de03d Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 10 May 2023 18:02:35 +0100
>Subject: [PATCH] Bug 33223: Fix sendshelf
>Content-Type: text/plain; charset=utf-8
>
>Two new occurences of first_valid crept in, this patch corrects those to
>also use notice_
>
>Signed-off-by: David Cook <dcook@prosentient.com.au>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> opac/opac-sendshelf.pl      | 2 +-
> virtualshelves/sendshelf.pl | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl
>index f5600a27e3..a90d2ca5f4 100755
>--- a/opac/opac-sendshelf.pl
>+++ b/opac/opac-sendshelf.pl
>@@ -61,7 +61,7 @@ if ( $shelf and $shelf->can_be_viewed($borrowernumber) ) {
>         my $comment = $query->param('comment');
> 
>         my $patron     = Koha::Patrons->find($borrowernumber);
>-        my $user_email = $patron->first_valid_email_address;
>+        my $user_email = $patron->notice_email_address;
>         my $shelf      = Koha::Virtualshelves->find($shelfid);
>         my $contents   = $shelf->get_contents;
>         my $iso2709;
>diff --git a/virtualshelves/sendshelf.pl b/virtualshelves/sendshelf.pl
>index 8deeffd96f..3a2738c2d8 100755
>--- a/virtualshelves/sendshelf.pl
>+++ b/virtualshelves/sendshelf.pl
>@@ -61,7 +61,7 @@ if ($to_address) {
>     my $comment = $query->param('comment');
> 
>     my $patron     = Koha::Patrons->find($borrowernumber);
>-    my $user_email = $patron->first_valid_email_address;
>+    my $user_email = $patron->notice_email_address;
>     my $contents   = $shelf->get_contents;
>     my @biblionumbers;
>     my $iso2709;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33223: 148168 | 151023 | 151024 | 151025 | 151041 | 151042 | 151117 | 151118