Bugzilla – Attachment 15112 Details for
Bug 9556
Changing patron category does not fully update patron messaging preferences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 9556: fix setting messaging prefs when changing patron category
SIGNED-OFF-Bug-9556-fix-setting-messaging-prefs-wh.patch (text/plain), 2.47 KB, created by
Owen Leonard
on 2013-02-06 16:20:47 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 9556: fix setting messaging prefs when changing patron category
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2013-02-06 16:20:47 UTC
Size:
2.47 KB
patch
obsolete
>From 6795be502b5c8cc466e210d4ae4b6eb7d29aaafc Mon Sep 17 00:00:00 2001 >From: Galen Charlton <gmc@esilibrary.com> >Date: Wed, 6 Feb 2013 08:02:18 -0800 >Subject: [PATCH] [SIGNED-OFF] Bug 9556: fix setting messaging prefs when > changing patron category >Content-Type: text/plain; charset="utf-8" > >As a result of accumulated changes to field names returned >by the members/default_messageprefs.pl service, the JavaScript >to change the patron messaging preferences to the category default >when changing a patron's category in the patron editor stopped >working. > >To test: > >[1] Turn on the EnhancedMessagingPreferences feature. >[2] Set message preference defaults for at least two > patron categories. >[3] Before applying the patch, create a new patron record > using one of the categories you set prefs for, then > change the category, then change it back again. You > will see that numeric settings like the number of days > for advanced notices will change, but checkboxes won't change. >[4] Apply the patch, then create a new patron record and > try changing the patron category. You will see that all of > the preferences will get updated to the category default > each time you change the category. > >Signed-off-by: Galen Charlton <gmc@esilibrary.com> >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/members/memberentrygen.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 5ceb365..edabba0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1404,8 +1404,8 @@ > var attrid = item.message_attribute_id; > var transports = ['email', 'rss', 'sms']; > $.each(transports, function(j, transport) { >- if (item['transport-' + transport] != ' ') { >- $('#' + transport + attrid).attr('checked', item['transport-' + transport]); >+ if (item['transports_' + transport] == 1) { >+ $('#' + transport + attrid).attr('checked', 'checked'); > } else { > $('#' + transport + attrid).removeAttr('checked'); > } >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9556
:
15110
|
15112
|
15134