Bugzilla – Attachment 151128 Details for
Bug 32993
Holds priority changed incorrectly with dropdown selector
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32993: Holds priority changed incorrectly with dropdown selector
Bug-32993-Holds-priority-changed-incorrectly-with-.patch (text/plain), 1.93 KB, created by
Marcel de Rooy
on 2023-05-12 09:49:40 UTC
(
hide
)
Description:
Bug 32993: Holds priority changed incorrectly with dropdown selector
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-05-12 09:49:40 UTC
Size:
1.93 KB
patch
obsolete
>From 0f03697910e6c80dd8f3eaaebb2b9a649fd537b9 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 28 Apr 2023 14:30:19 -0400 >Subject: [PATCH] Bug 32993: Holds priority changed incorrectly with dropdown > selector >Content-Type: text/plain; charset=utf-8 > >Test Plan: >1) Find record with at least 3 holds. >2) Change first holds priority as 2, Priority is changed to 3. >3) Try to change priority back to 1, Priority is changed to 2. >4) Apply this patch >5) Reload the page >2) Change first holds priority as 2, Priority is changed to 2. >3) Try to change priority back to 1, Priority is changed to 1. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 1008163734..5ab790f73a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -1623,7 +1623,7 @@ > var value = parseInt($(this).val()); > var found_holds = $("select[name='rank-request'][disabled='disabled']").length ; //Count how many are found > if( !isNaN(value) ) { //If moved to 'del' >- var after = row.parent().find("tr:nth-child("+(value+1+found_holds )+")"); //Go to the row 1 after the new value (and skip found holds) >+ var after = row.parent().find(`tr:nth-child(${value+found_holds})`); //Go to the row 1 after the new value (and skip found holds) > if (prev_rank_request > value) { > row.insertBefore(after); > } else { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32993
:
150411
|
150417
|
150496
|
150803
| 151128