Attachment 151197 Details for Bug 32092 – Bug 32092: Fix uninitialized value in addition

[patch] Bug 32092: Fix uninitialized value in addition

Bug-32092-Fix-uninitialized-value-in-addition.patch (text/plain), 1002 bytes, created by David Gustafsson on 2023-05-15 14:08:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Gustafsson

Created: 2023-05-15 14:08:24 UTC

Size: 1002 bytes

patch

obsolete

>From cf26f61cad649641669e53a822bd6522bd59fb01 Mon Sep 17 00:00:00 2001
>From: David Gustafsson <david.gustafsson@ub.gu.se>
>Date: Mon, 15 May 2023 16:08:09 +0200
>Subject: [PATCH] Bug 32092: Fix uninitialized value in addition
>
>---
> Koha/Patron.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/Patron.pm b/Koha/Patron.pm
>index 0c70f333d5a..758866a2ea8 100644
>--- a/Koha/Patron.pm
>+++ b/Koha/Patron.pm
>@@ -1088,15 +1088,15 @@ sub article_request_fee {
> 
>     $library_id //= C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef;
> 
>-    my $fee = Koha::CirculationRules->get_effective_rule_value(
>+    my $value = Koha::CirculationRules->get_effective_rule_value(
>         {
>             branchcode   => $library_id,
>             categorycode => $self->categorycode,
>             rule_name    => 'article_request_fee'
>         }
>-    ) + 0;
>+    );
> 
>-    return $fee;
>+    return $value ? $value + 0 : 0;
> }
> 
> =head3 add_article_request_fee_if_needed
>-- 
>2.40.0

Actions: View | Diff | Splinter Review

Attachments on bug 32092: 143120 | 146956 | 147149 | 147150 | 147151 | 149782 | 149783 | 151195 | 151196 | 151197 | 151709 | 151710 | 151711 | 153168 | 153169 | 153170 | 157534 | 157535 | 157536 | 157537 | 157551