Bugzilla – Attachment 151240 Details for
Bug 33733
Move t/XSLT.t to db_dependent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33733: Remove need for Test::DBIx::Class
Bug-33733-Remove-need-for-TestDBIxClass.patch (text/plain), 1.71 KB, created by
David Nind
on 2023-05-16 02:59:11 UTC
(
hide
)
Description:
Bug 33733: Remove need for Test::DBIx::Class
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-05-16 02:59:11 UTC
Size:
1.71 KB
patch
obsolete
>From a5b1f455542df51a464ff94672d3bf3ebcc19704 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 15 May 2023 06:58:45 +0000 >Subject: [PATCH] Bug 33733: Remove need for Test::DBIx::Class > >Test plan: >Run t/XSLT.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: David Nind <david@davidnind.com> >--- > t/XSLT.t | 23 ++++++----------------- > 1 file changed, 6 insertions(+), 17 deletions(-) > >diff --git a/t/XSLT.t b/t/XSLT.t >index e3a733251c..ee1c01e9e9 100755 >--- a/t/XSLT.t >+++ b/t/XSLT.t >@@ -16,33 +16,22 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; >-use Test::More; >+use Test::More tests => 1; > > use File::Temp; > use File::Path qw/make_path/; > > use t::lib::Mocks; > >-use Module::Load::Conditional qw/check_install/; >- >-BEGIN { >- if ( check_install( module => 'Test::DBIx::Class' ) ) { >- plan tests => 9; >- } else { >- plan skip_all => "Need Test::DBIx::Class" >- } >- >- use_ok('C4::XSLT'); >-}; >- >-use Test::DBIx::Class; >-my $db = Test::MockModule->new('Koha::Database'); >-$db->mock( _new_schema => sub { return Schema(); } ); >+use C4::XSLT; > > my $dir = File::Temp->newdir(); > my @themes = ('prog', 'test'); > my @langs = ('en', 'es-ES'); > >+subtest 'Tests moved from t' => sub { >+ plan tests => 8; >+ > # create temporary files to be tested later > foreach my $theme (@themes) { > foreach my $lang (@langs) { >@@ -76,4 +65,4 @@ is(find_and_slurp($dir, 'nope', 'fr-FR'), 'Theme prog, language en', 'Fell ba > my $matching_string = q{<syspref name="singleBranchMode">0</syspref>}; > my $sysprefs_xml = C4::XSLT::get_xslt_sysprefs(); > ok( $sysprefs_xml =~ m/$matching_string/, 'singleBranchMode has a value of 0'); >- >+}; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33733
:
151185
|
151186
|
151187
|
151240
|
151241
|
151242
|
151265
|
151266
|
151267