Attachment 151245 Details for Bug 33553 – Bug 33553: Remove unecessary GetCategories calls in templates

[patch] Bug 33553: Remove unecessary GetCategories calls in templates

Bug-33553-Remove-unecessary-GetCategories-calls-in.patch (text/plain), 2.68 KB, created by Jonathan Druart on 2023-05-16 06:49:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-05-16 06:49:27 UTC

Size: 2.68 KB

patch

obsolete

>From 7ff21b82c0de800f9cb278980d0db51931de28d1 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 15 May 2023 11:43:04 +0000
>Subject: [PATCH] Bug 33553: Remove unecessary GetCategories calls in templates
>
>This patch removes unnecessary references to
>AuthorisedValues.GetCategories:
>
>SET AuthorisedValuesCategories = AuthorisedValues.GetCategories
>
>The AuthorisedValuesCategories variable is not used.
>
>To test, apply the patch and go to Tools -> Patron clubs.
>
>- If necessary, create a club template with "Allow public enrollment"
>  enabled.
>- Create a new club. The club creation process should work correctly.
>- Open a patron account for checkout and confirm that you can enroll the
>  patron in the new club via the "Clubs" tab.
>- Log in to the OPAC and confirm that you can successfully enroll
>  yourself in the new club via the "Clubs" tab on your patron summary
>  page.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt      | 1 -
> koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt   | 1 -
> koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt         | 1 -
> 3 files changed, 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt
>index 1633f42d323..ebbb27897ad 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt
>@@ -3,7 +3,6 @@
> [% USE KohaDates %]
> [% USE Branches %]
> [% USE AuthorisedValues %]
>-[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt
>index 13f209ba464..d120da0d078 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt
>@@ -1,5 +1,4 @@
> [% USE AuthorisedValues %]
>-[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %]
> 
> <h1>
>     Enroll in <em>[% club.name | html %]</em>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt
>index 6f6d62ee82e..b83e1e31567 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt
>@@ -1,5 +1,4 @@
> [% USE AuthorisedValues %]
>-[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %]
> 
> <h2>
>     Enroll in <em>[% club.name | html %]</em>
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 33553: 151200 | 151245