Attachment 151298 Details for Bug 29440 – Bug 29440: Remove pointless call to _strip_item_fields

[patch] Bug 29440: Remove pointless call to _strip_item_fields

Bug-29440-Remove-pointless-call-to-stripitemfields.patch (text/plain), 1.56 KB, created by David Gustafsson on 2023-05-16 14:44:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Gustafsson

Created: 2023-05-16 14:44:28 UTC

Size: 1.56 KB

patch

obsolete

>From 1fc1df988efe6b02dea0e47e3b85ebddc86b5328 Mon Sep 17 00:00:00 2001
>From: David Gustafsson <david.gustafsson@ub.gu.se>
>Date: Mon, 26 Sep 2022 16:09:30 +0200
>Subject: [PATCH] Bug 29440: Remove pointless call to _strip_item_fields
>
>---
> misc/migration_tools/bulkmarcimport.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl
>index e49770449c6..8eb0a7515a1 100755
>--- a/misc/migration_tools/bulkmarcimport.pl
>+++ b/misc/migration_tools/bulkmarcimport.pl
>@@ -561,9 +561,9 @@ RECORD: foreach my $record (@{$marc_records}) {
>             if ($record_id) {
>                 $yamlhash->{$originalid} = $record_id if $yamlfile;
>                 eval { ($itemnumbers_ref, $errors_ref) = AddItemBatchFromMarc($record, $record_id, $biblioitemnumber, $framework); };
>+                my $error_adding = $@;
>                 $record_has_added_items = @{$itemnumbers_ref};
> 
>-                my $error_adding = $@;
>                 # Work on a clone so that if there are real errors, we can maybe
>                 # fix them up later.
>                 my $clone_record = $record->clone();
>@@ -632,7 +632,7 @@ RECORD: foreach my $record (@{$marc_records}) {
>                 if (@{$errors_ref}) {
>                     report_item_errors($record_id, $errors_ref);
>                 }
>-                C4::Biblio::_strip_item_fields($record, $framework);
>+
>                 my $biblio = Koha::Biblios->find($record_id);
>                 $record = $biblio->metadata->record( { embed_items => 1 } );
> 
>-- 
>2.40.0

Actions: View | Diff | Splinter Review

Attachments on bug 29440: 127479 | 127480 | 127481 | 127485 | 127486 | 127508 | 127509 | 127651 | 127652 | 127791 | 127792 | 127795 | 127796 | 127959 | 127960 | 127961 | 127963 | 128086 | 128087 | 128362 | 128890 | 128891 | 131176 | 131177 | 131180 | 131181 | 132942 | 140822 | 140823 | 140903 | 140904 | 140905 | 140906 | 140924 | 140925 | 140926 | 140927 | 140928 | 140987 | 140988 | 140989 | 143375 | 151293 | 151294 | 151295 | 151296 | 151297 | 151298 | 151299 | 151300 | 151301 | 157798 | 160148 | 160149 | 160150 | 160151 | 160152 | 160153 | 160154 | 160155 | 160156 | 160157 | 160477 | 160478 | 160479 | 160480 | 160481 | 160482 | 160483 | 160484 | 160485 | 160486 | 160487