Attachment 151337 Details for Bug 33713 – Bug 33713: Make batch operations from report results open in new tab

[patch] Bug 33713: Make batch operations from report results open in new tab

Bug-33713-Make-batch-operations-from-report-result.patch (text/plain), 5.27 KB, created by Marcel de Rooy on 2023-05-17 13:39:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-05-17 13:39:01 UTC

Size: 5.27 KB

patch

obsolete

>From a8c178d1fc24cb39f965e6c9c1a0361985d9b666 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 12 May 2023 18:06:57 +0000
>Subject: [PATCH] Bug 33713: Make batch operations from report results open in
> new tab
>Content-Type: text/plain; charset=utf-8
>
>To test:
>1. Have some reports that can do the following batch operations:
>    -Batch patron mod
>    -Batch item deletion
>    -Batch add to list
>    -Batch item mod
>    -Batch record delection
>    -Batch record mod
>
>2. Run the report ann click 'Batch operations with X visible records', make sure each batch op opens in a new tab.
>
>These two simple reports should allow you to test each of the batch cases:
>
>select * from items limit 1
>select * from borrowers limit 1
>
>Signed-off-by: Andrew  Fuerste-Henry <andrewfh@dubcolib.org>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../prog/en/modules/reports/guided_reports_start.tt  | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 7b4fee60d5..cbc7326deb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -916,7 +916,7 @@
> 
>                         [% IF ( execute ) %]
>                             [% UNLESS ( errors ) %]
>-                                <form method="post" enctype="multipart/form-data" action="/cgi-bin/koha/tools/batch_record_modification.pl" id="batch_record_modification">
>+                                <form method="post" enctype="multipart/form-data" action="/cgi-bin/koha/tools/batch_record_modification.pl" id="batch_record_modification" target="_blank">
>                                     <input type="hidden" name="recordtype" value="biblio" />
>                                     <input type="hidden" name="op" value="list" />
>                                     [% # Preserve the whitespace of the following textarea in order to format the values correctly %]
>@@ -925,7 +925,7 @@
>                                     </textarea>
>                                 </form>
> 
>-                                <form method="POST" action="/cgi-bin/koha/tools/batch_delete_records.pl" id="batch_record_deletion">
>+                                <form method="POST" action="/cgi-bin/koha/tools/batch_delete_records.pl" id="batch_record_deletion" target="_blank">
>                                     <input type="hidden" name="recordtype" value="biblio" />
>                                     <input type="hidden" name="op" value="list" />
>                                     [% # Preserve the whitespace of the following textarea in order to format the values correctly %]
>@@ -934,7 +934,7 @@
>                                     </textarea>
>                                 </form>
> 
>-                                <form method="POST" action="/cgi-bin/koha/tools/batchMod.pl" id="batch_item_modification">
>+                                <form method="POST" action="/cgi-bin/koha/tools/batchMod.pl" id="batch_item_modification" target="_blank">
>                                     <input type="hidden" name="op" value="show" />
>                                     [% FOREACH result IN results %]
>                                         [% FOREACH cells IN result.cells %]
>@@ -949,7 +949,7 @@
>                                     [% END %]
>                                 </form>
> 
>-                                <form method="POST" action="/cgi-bin/koha/tools/batchMod.pl" id="batch_item_deletion">
>+                                <form method="POST" action="/cgi-bin/koha/tools/batchMod.pl" id="batch_item_deletion" target="_blank">
>                                     <input type="hidden" name="op" value="show" />
>                                     <input type="hidden" name="del" value="1" />
>                                     [% FOREACH result IN results %]
>@@ -965,7 +965,7 @@
>                                     [% END %]
>                                 </form>
> 
>-                                <form method="get" action="/cgi-bin/koha/virtualshelves/addbybiblionumber.pl" id="batch_add_to_list">
>+                                <form method="get" action="/cgi-bin/koha/virtualshelves/addbybiblionumber.pl" id="batch_add_to_list" target="_blank">
>                                     [% FOREACH result IN results %]
>                                         [% FOREACH cells IN result.cells %]
>                                             [% place = loop.index %]
>@@ -979,7 +979,7 @@
>                                     [% END %]
>                                 </form>
> 
>-                                <form method="POST" action="/cgi-bin/koha/tools/modborrowers.pl" id="batch_patron_modification">
>+                                <form method="POST" action="/cgi-bin/koha/tools/modborrowers.pl" id="batch_patron_modification" target="_blank">
>                                     <input type="hidden" name="op" value="show" />
>                                     [% # Preserve the whitespace of the following textarea in order to format the values correctly %]
>                                     <textarea style="display:none" name="cardnumberlist" id="cardnumberlist">
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33713: 151157 | 151159 | 151337