Attachment 151371 Details for Bug 30979 – Bug 30979: Limit public checkout endpoint using preference

[patch] Bug 30979: Limit public checkout endpoint using preference

Bug-30979-Limit-public-checkout-endpoint-using-pre.patch (text/plain), 1.87 KB, created by Martin Renvoize (ashimema) on 2023-05-17 19:01:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-05-17 19:01:58 UTC

Size: 1.87 KB

patch

obsolete

>From e530e96e79040a78378a3482d317cf86e35588fd Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 6 Mar 2023 17:32:32 +0000
>Subject: [PATCH] Bug 30979: Limit public checkout endpoint using preference
>
>The public api endpoint for self-checkout should only be enabled in the
>case where the OpacTrustedSelfCheckout option is enabled.
>
>Signed-off-by: Silvia Meakins <smeakins@eso.org>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/REST/V1/Checkouts.pm                | 12 ++++++++++++
> api/v1/swagger/paths/public_patrons.yaml |  4 ++++
> 2 files changed, 16 insertions(+)
>
>diff --git a/Koha/REST/V1/Checkouts.pm b/Koha/REST/V1/Checkouts.pm
>index 0689601908..42b9f4b4b6 100644
>--- a/Koha/REST/V1/Checkouts.pm
>+++ b/Koha/REST/V1/Checkouts.pm
>@@ -191,6 +191,18 @@ sub add {
>     my $patron_id = $body->{patron_id};
>     my $onsite    = $body->{onsite_checkout};
> 
>+    if ( $c->stash('is_public')
>+        && !C4::Context->preference('OpacTrustedCheckout') )
>+    {
>+        return $c->render(
>+            status  => 405,
>+            openapi => {
>+                error      => 'Feature disabled',
>+                error_code => 'FEATURE_DISABLED'
>+            }
>+        );
>+    }
>+
>     return try {
>         my $item = Koha::Items->find($item_id);
>         unless ($item) {
>diff --git a/api/v1/swagger/paths/public_patrons.yaml b/api/v1/swagger/paths/public_patrons.yaml
>index fb50548fd0..d5c82916ab 100644
>--- a/api/v1/swagger/paths/public_patrons.yaml
>+++ b/api/v1/swagger/paths/public_patrons.yaml
>@@ -102,6 +102,10 @@
>         description: Cannot create checkout
>         schema:
>           $ref: "../swagger.yaml#/definitions/error"
>+      "405":
>+        description: Method not allowed
>+        schema:
>+          $ref: "../swagger.yaml#/definitions/error"
>       "409":
>         description: Conflict in creating checkout
>         schema:
>-- 
>2.40.1

Actions: View | Diff | Splinter Review

Attachments on bug 30979: 139131 | 139132 | 139133 | 139134 | 141274 | 141275 | 141276 | 141277 | 141278 | 141279 | 141300 | 145264 | 145265 | 145266 | 145267 | 145268 | 145277 | 145280 | 145281 | 145282 | 145283 | 145284 | 145285 | 145620 | 145621 | 145622 | 145623 | 145624 | 145625 | 145626 | 145627 | 145628 | 145629 | 145630 | 150867 | 150868 | 150869 | 150870 | 150871 | 150872 | 150873 | 150874 | 150875 | 150876 | 150877 | 150878 | 150879 | 150880 | 150881 | 150882 | 150883 | 150884 | 150885 | 150886 | 150887 | 150888 | 150889 | 150967 | 150968 | 150969 | 150970 | 150971 | 150972 | 150973 | 150974 | 151254 | 151255 | 151256 | 151257 | 151258 | 151259 | 151260 | 151261 | 151358 | 151359 | 151360 | 151361 | 151362 | 151363 | 151364 | 151365 | 151368 | 151369 | 151370 | 151371 | 151372 | 151373 | 151374 | 151375 | 151376 | 152789 | 152790 | 152791 | 152792 | 152793 | 152794 | 152795 | 152796 | 152797 | 153459 | 153460 | 153461 | 153462 | 153463 | 153464 | 153465 | 153466 | 153467 | 153500 | 153501 | 153502 | 153503