Attachment 15139 Details for Bug 9034 – Bug 9034 [Follow-up] Add sorting and filtering on items table (catalogue/detail.pl)

[patch] Bug 9034 [Follow-up] Add sorting and filtering on items table (catalogue/detail.pl)

Bug-9034-Follow-up-Add-sorting-and-filtering-on-it.patch (text/plain), 2.12 KB, created by Jonathan Druart on 2013-02-07 14:26:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2013-02-07 14:26:28 UTC

Size: 2.12 KB

patch

obsolete

>From ce526786d6f968e94d00f19b96a0f44e3948dc67 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 9 Nov 2012 14:48:14 -0500
>Subject: [PATCH] Bug 9034 [Follow-up] Add sorting and filtering on items
> table (catalogue/detail.pl)
>
>This follow-up to the original patch offers an alternative method
>to handle the width of the table and form fields:
>
>- Reduce the font size of the filter input fields
>- Make the filter inputs' width 100% instead of fixed
>- Add "'bAutoWidth': false" to the datatables initialization
>  to prevent the table width from being set to the browser window
>  width on load. This allows the browser to be re-sized and have
>  the table re-flow with it.
>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/css/datatables.css          |    3 ++-
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt |    3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/datatables.css b/koha-tmpl/intranet-tmpl/prog/en/css/datatables.css
>index 179979f..92e1768 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/datatables.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/datatables.css
>@@ -227,5 +227,6 @@ tr.even.selected td {
> 
> /* ColumnFilter */
> span.filter_column > input.text_filter {
>-    width: 7em;
>+    font-size: 80%;
>+    width: 100%;
> }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index a0fd3b5..1763962 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -56,7 +56,8 @@ function verify_images() {
>         for (id in {holdings:0, otherholdings:0}) {
>             $("#"+ id +" > table").dataTable($.extend(true, {}, dataTablesDefaults, {
>                 'sDom': 't',
>-                'bPaginate': false
>+                'bPaginate': false,
>+                'bAutoWidth': false
>             })).columnFilter({
>                 'sPlaceHolder': 'head:after'
>             });
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 9034: 13310 | 13338 | 13345 | 13346 | 13368 | 14491 | 14492 | 14493 | 14494 | 14743 | 15137 | 15138 | 15139 | 15140