Attachment 151417 Details for Bug 33313 – Bug 33313: Fix catalog links in TICKET_NOTIFY

[patch] Bug 33313: Fix catalog links in TICKET_NOTIFY

Bug-33313-Fix-catalog-links-in-TICKETNOTIFY.patch (text/plain), 3.35 KB, created by Martin Renvoize (ashimema) on 2023-05-18 13:22:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-05-18 13:22:44 UTC

Size: 3.35 KB

patch

obsolete

>From 956332d2dd7c31e3e57807f51eb1ae9e312099e0 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 23 Apr 2023 11:57:46 +0000
>Subject: [PATCH] Bug 33313: Fix catalog links in TICKET_NOTIFY
>
>This fixes the system preference name from IntranetBaseURL to
>staffClientBaseURL.
>
>As this feature has just been pushed I chose to fix the
>database updates that will be run when installing 23.05.
>
>To test:
>* Verify the wrong link in TICKET_NOTIFY
>* Drop database, create database, run web installer
>* Verify the link is now correct in the notice
>
>Bonus: Test update from 22.11 to 23.05 and verify the
>notices are correct there as well.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> installer/data/mysql/db_revs/221200010.pl | 2 +-
> installer/data/mysql/en/mandatory/sample_notices.yml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/installer/data/mysql/db_revs/221200010.pl b/installer/data/mysql/db_revs/221200010.pl
>index e7e033c3d2..2a4921d4be 100755
>--- a/installer/data/mysql/db_revs/221200010.pl
>+++ b/installer/data/mysql/db_revs/221200010.pl
>@@ -121,7 +121,7 @@ return {
> $dbh->do(
> q{
> INSERT IGNORE INTO letter(module,code,branchcode,name,is_html,title,content,message_transport_type)
>- VALUES ( 'catalogue', 'TICKET_NOTIFY', '', 'Catalog concern notification', '1', 'Catalog concern reported', "[%- USE Koha -%][%- PROCESS 'html_helpers.inc' -%]\r\nDear cataloger, [%- INCLUDE 'patron-title.inc' patron => ticket.reporter -%]reported the following concern with [%- INCLUDE 'biblio-title.inc' biblio=ticket.biblio link = 1 -%] [%- ticket.body -%] You can mark this concern as resolved from the concern management <a href='[%- Koha.Preference('IntranetBaseURL') -%]/cgi-bin/koha/cataloguing/concerns.pl'>page</a>.", 'email' );
>+ VALUES ( 'catalogue', 'TICKET_NOTIFY', '', 'Catalog concern notification', '1', 'Catalog concern reported', "[%- USE Koha -%][%- PROCESS 'html_helpers.inc' -%]\r\nDear cataloger, [%- INCLUDE 'patron-title.inc' patron => ticket.reporter -%]reported the following concern with [%- INCLUDE 'biblio-title.inc' biblio=ticket.biblio link = 1 -%] [%- ticket.body -%] You can mark this concern as resolved from the concern management <a href='[%- Koha.Preference('staffClientBaseURL') -%]/cgi-bin/koha/cataloguing/concerns.pl'>page</a>.", 'email' );
> }
> );
> say $out "Added new notice 'TICKET_NOTIFY'";
>diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml
>index fd4ed6768f..8976840cec 100644
>--- a/installer/data/mysql/en/mandatory/sample_notices.yml
>+++ b/installer/data/mysql/en/mandatory/sample_notices.yml
>@@ -116,7 +116,7 @@ tables:
> - " "
> - "[%- ticket.body -%] "
> - " "
>- - "You can mark this concern as resolved from the concern management <a href='[%- Koha.Preference('IntranetBaseURL') -%]/cgi-bin/koha/cataloguing/concerns.pl'>page</a>."
>+ - "You can mark this concern as resolved from the concern management <a href='[%- Koha.Preference('staffClientBaseURL') -%]/cgi-bin/koha/cataloguing/concerns.pl'>page</a>."
> 
> - module: circulation
> code: ACCOUNT_CREDIT
>-- 
>2.40.1

Actions: View | Diff | Splinter Review

Attachments on bug 33313: 150130 | 150135 | 151384 | 151417