Bugzilla – Attachment 151433 Details for
Bug 33195
Reindent the bibliographic details page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33195: (follow-up) Add markup comments
Bug-33195-follow-up-Add-markup-comments.patch (text/plain), 37.65 KB, created by
Owen Leonard
on 2023-05-18 18:02:17 UTC
(
hide
)
Description:
Bug 33195: (follow-up) Add markup comments
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2023-05-18 18:02:17 UTC
Size:
37.65 KB
patch
obsolete
>From a9a4656740c695a09914d5f15d7b9523e0c01774 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 17 May 2023 11:25:44 +0000 >Subject: [PATCH] Bug 33195: (follow-up) Add markup comments > >This patch adds comments to the template to highlight the markup >structure. > >This patch should have no effect on the page's appearance or >functionality. >--- > .../prog/en/modules/catalogue/detail.tt | 250 +++++++++--------- > 1 file changed, 125 insertions(+), 125 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 712b84794a..6eb7d6a4d3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -126,7 +126,7 @@ > [% IF ( loop.last ) %][% ELSE %]|[% END %] > [% END %] > </span> >- [% END %] >+ [% END # /IF shelves.count %] > > [% IF ( TagsEnabled && TagsShowOnDetail && TagLoop ) %] > <span class="results_summary"><span class="label">Tags:</span> >@@ -139,7 +139,7 @@ > <span class="weight">([% TagLoo.weight_total | html %])</span>[% IF ( loop.last ) %][% ELSE %], [% END %] > [% END %] > </span> >- [% END %] >+ [% END # /IF TagsEnabled %] > > <span id="catalogue_detail_marc_preview" class="results_summary"> > <span class="label">MARC preview:</span> >@@ -163,14 +163,14 @@ > <span class="itypetext">[% itemtype | html %]</span> > [% END %] > </span> >- [% END %] >+ [% END # /IF !item_level_itypes %] > > [% IF ( Koha.Preference('SearchEngine') == 'Elasticsearch' ) %] > <span id="catalogue_detail_elastic_record" class="results_summary"> > <span class="label">Elasticsearch record:</span> > <a href="/cgi-bin/koha/catalogue/showelastic.pl?id=[% biblionumber | uri %]" title="Elasticsearch record" class="previewElastic">Show</a> > </span> >- [% END %] >+ [% END # /IF Elasticsearch %] > > [% IF ( holdcount ) %] > <span class="results_summary"> >@@ -183,7 +183,7 @@ > [% END %] > </span> > </span> >- [% END %] >+ [% END # /IF ( holdcount ) %] > > [% IF illrequests.count %] > <span class="results_summary"> >@@ -198,7 +198,7 @@ > [% END %] > [% END %] > </span> >- [% END %] >+ [% END # /IF illrequests.count %] > > [% IF ( article_requests_count = Biblio.ArticleRequestsActiveCount( biblionumber ) ) %] > <span class="results_summary"> >@@ -207,7 +207,7 @@ > <a href="/cgi-bin/koha/circ/request-article.pl?biblionumber=[% biblionumber | uri %]">[% article_requests_count | html %]</a> > </span> > </span> >- [% END %] >+ [% END # /IF article_requests_count %] > > [% IF course_reserves %] > <span class="results_summary"> >@@ -217,11 +217,11 @@ > [% IF ( loop.last ) %][% ELSE %]|[% END %] > [% END %] > </span> >- [% END %] >- </div> [%# .page-section %] >+ [% END # /IF course_reserves %] >+ </div> <!-- /.page-section --> > > [% IF ( CoverImagePlugins || AmazonCoverImages || LocalCoverImages || IntranetCoce || ( SyndeticsCovers ) || (Koha.Preference('CustomCoverImages') && Koha.Preference('CustomCoverImagesURL')) ) %] >- </div> >+ </div> <!-- /.col-xs-* --> > <div class="col-xs-3 bookcoverimg"> > <div id="biblio-cover-slider" class="cover-slider" data-isbn="[% normalized_isbn | html %]"> > [% IF ( LocalCoverImages ) %] >@@ -232,10 +232,10 @@ > <img src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1&imagenumber=[% image.imagenumber | uri %]" alt="Local cover image" data-link="/cgi-bin/koha/catalogue/imageviewer.pl?biblionumber=[% biblionumber | uri %]&imagenumber=[% image.imagenumber | uri %]" /> > </a> > <div class="hint">Local cover image</div> >- </div> >- [% END %] >- [% END %] >- [% END %] >+ </div> <!-- /.cover-image --> >+ [% END # FOREACH image %] >+ [% END # /IF localimages.count %] >+ [% END # /IF ( LocalCoverImages ) %] > > [% IF ( AmazonCoverImages && normalized_isbn) %] > <div class="cover-image" id="amazon-bookcoverimg"> >@@ -243,8 +243,8 @@ > <img src="https://images-na.ssl-images-amazon.com/images/P/[% normalized_isbn | uri %].01.MZZZZZZZ.jpg" alt="Amazon cover image" data-link="http://www.amazon[% AmazonTld | uri %]/gp/reader/[% normalized_isbn | uri %][% AmazonAssocTag | uri %]#reader-link"/> > </a> > <div class="hint">Image from Amazon.com</div> >- </div> >- [% END %] >+ </div> <!-- /.cover-image --> >+ [% END # /IF ( AmazonCoverImages && normalized_isbn) %] > > [% IF ( IntranetCoce && CoceProviders && normalized_isbn ) %] > [% coce_id = normalized_ean || normalized_isbn %] >@@ -255,8 +255,8 @@ > <span class="no-image">No cover image available</span> > [% END %] > <div class="hint">Image from Coce</div> >- </div> >- [% END %] >+ </div> <!-- /.cover-image --> >+ [% END # /IF IntranetCoce %] > > [% IF ( SyndeticsCovers ) %] > [% IF ( content_identifier_exists ) %] >@@ -265,7 +265,7 @@ > <img src="https://secure.syndetics.com/index.aspx?isbn=[% normalized_isbn | url %]/[% Koha.Preference('SyndeticsCoverImageSize') | url %].GIF&client=[% Koha.Preference('SyndeticsClientCode') | url %]&type=xw10&upc=[% normalized_upc | url %]&oclc=[% normalized_oclc | url %]" alt="" class="thumbnail" /> > </a> > <div class="hint">Image from Syndetics</div> >- </div> >+ </div> <!-- /.cover-image --> > [% ELSE %] > <span class="no-image">No cover image available</span> > [% END %] >@@ -279,15 +279,15 @@ > <img id="custom-img" alt="Custom cover image" src="[% custom_cover_image_url | url %]" /> > </a> > <div class="hint">Custom cover image</div> >- </div> >- [% END %] >- [% END %] >+ </div> <!-- /.cover-image --> >+ [% END # /custom_cover_image_url %] >+ [% END # /IF CustomCoverImages %] > </div> <!-- /.cover-slider --> > </div> <!-- /.bookcoverimg.col-xs-3 --> > [% ELSE %] > </div> <!-- /.col-xs-* --> > [% END # /IF ( AmazonCoverImages, etc ) %] >- </div> >+ </div> <!-- /.row --> > > <div id="bibliodetails" class="toptabs"> > <ul class="nav nav-tabs" role="tablist"> >@@ -302,7 +302,7 @@ > <li role="presentation"> > <a href="#holdings" aria-controls="holdings" role="tab" data-toggle="tab">Holdings ([% itemloop.size() || 0 | html %])</a> > </li> >- [% END %] >+ [% END # /IF (SeparateHoldings) %] > [% IF Koha.Preference('EnableItemGroups') %] > <li role="presentation"> > <a href="#item_groups" aria-controls="item_groups" role="tab" data-toggle="tab">Item groups</a> >@@ -362,8 +362,8 @@ > <li role="presentation"> > <a href="#[% plugins_intranet_catalog_biblio_tab.id | uri %]" aria-controls="[% plugins_intranet_catalog_biblio_tab.id | uri %]" role="tab" data-toggle="tab">[% plugins_intranet_catalog_biblio_tab.title | html %]</a> > </li> >- [% END %] >- </ul> >+ [% END # /FOREACH plugins_intranet_catalog_biblio_tab %] >+ </ul> <!-- /.nav.nav-tabs --> > > <div class="tab-content"> > [% items_table_block_iter = 0 %] >@@ -385,9 +385,9 @@ > <a class="itemselection_action_item_group_set" href="#"><i class="fa fa-book"></i> Add/move to item group</a> > <a class="itemselection_action_item_group_unset" href="#"><i class="fa fa-unlink"></i> Remove from item group</a> > [% END %] >- </span> >- [% END %] >- </div> >+ </span> <!-- /.itemselection_actions --> >+ [% END # /IF (StaffDetailItemSelection) %] >+ </div> <!-- /.tab_table_table_controls --> > > <table class="items_table" id="[% tab | html %]_table"> > <thead> >@@ -757,21 +757,21 @@ > <ul class="dropdown-menu pull-right"> > <li><a href="/cgi-bin/koha/tools/upload-cover-image.pl?itemnumber=[% item.itemnumber | uri %]&filetype=image"><i class="fa fa-upload"></i> Upload image</a></li> > </ul> >- </div> >+ </div> <!-- /.btn-group --> > [% ELSE %] > <a class="btn btn-default btn-xs" href="/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=[% item.biblionumber | html %]&itemnumber=[% item.itemnumber | html %]#edititem"><i class="fa fa-pencil"></i> Edit</a> >- [% END %] >- [% END %] >+ [% END # /IF LocalCoverImages %] >+ [% END # /IF item.can_be_edited %] > [% IF bundlesEnabled %] > <button class="btn btn-default btn-xs details-control"><i class="fa fa-folder"></i> Manage bundle ([% item.bundled | html %]|[% item.bundled_lost | html %])</button> > [% END %] >- </td> >- [% END %] >+ </td> <!-- /.actions --> >+ [% END # /IF CAN_user_editcatalogue_edit_items %] > </tr> >- [% END %] >+ [% END # /FOREACH item %] > </tbody> >- </table> >- [% END %][%# end of block items_table %] >+ </table> <!-- /.items_table --> >+ [% END %][% # /BLOCK items_table %] > > [% IF Koha.Preference('EnableItemGroups') %] > <div role="tabpanel" class="tab-pane" id="item_groups"> >@@ -789,8 +789,8 @@ > </tr> > </thead> > </table> >- </div> >- [% END %] >+ </div> <!-- /.tab-pane --> >+ [% END # /IF EnableItemGroups %] > > <div role="tabpanel" class="tab-pane" id="holdings"> > [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectStaffProfile') && Koha.Preference('NovelistSelectStaffView') == 'above' ) %] >@@ -826,7 +826,7 @@ > [% ELSE %] > <div id="noitems">No physical items for this record</div> > [% END %] >- [% END %] >+ [% END # /IF count %] > > [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectStaffProfile') && Koha.Preference('NovelistSelectStaffView') == 'below' ) %] > <span class="results_summary NovelistSelect" style="display:none;"> >@@ -834,7 +834,7 @@ > <div data-novelist-novelistselect=[% normalized_isbn | html %]></div> > </span> > [% END %] >- </div> >+ </div> <!-- /.tab-pane#holdings --> > > [% IF (SeparateHoldings) %] > <div role="tabpanel" class="tab-pane" id="otherholdings"> >@@ -843,7 +843,7 @@ > [% ELSE %] > <span class="nootheritems">No other items.</span> > [% END %] >- </div> >+ </div> <!-- /.tab-pane#otherholdings --> > [% END %] > > [% IF ( MARCNOTES ) %] >@@ -857,10 +857,10 @@ > [% MARCNOTE.marcnote | html | html_line_break %] > [% END %] > </p> >- [% END %] >- </div> >- </div> >- [% END %] >+ [% END # /FOREACH MARCNOTE %] >+ </div> <!-- /.content_set --> >+ </div> <!-- /.tab-pane#description --> >+ [% END # /IF MARCNOTES %] > > [% IF ComponentParts && ComponentParts.size %] > <div role="tabpanel" class="tab-pane" id="components"> >@@ -878,8 +878,8 @@ > <p>Only [% ComponentParts.size | html %] results are shown: <a href="/cgi-bin/koha/catalogue/search.pl?q=[% ComponentPartsQuery | url %]"/>show all component parts</a></p> > [% END %] > </div> <!-- /.content_set --> >- </div> <!-- /#components --> >- [% END %] >+ </div> <!-- /.tab-pane#components --> >+ [% END # /IF ComponentParts %] > > [% IF ( subscriptionsnumber ) %] > <div role="tabpanel" class="tab-pane" id="subscriptions"> >@@ -930,14 +930,14 @@ > </td> > <td>[% latestserial.notes | html %]</td> > </tr> >- [% END %] >+ [% END # /FOREACH latestserial %] > </table> >- [% END %] >+ [% END # /IF ( subscription.latestserials ) %] > <a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscription.subscriptionid | uri %]">Subscription details</a> >- [% END %] >- </div> >- </div> >- [% END %] >+ [% END # /FOREACH subscription %] >+ </div> <!-- /#catalogue_detail_subscriptions --> >+ </div> <!-- /.tab-pane#subscriptions --> >+ [% END # /IF ( subscriptionsnumber %] > > [% IF Koha.Preference('AcquisitionDetails') %] > <div role="tabpanel" class="tab-pane" id="acq_details"> >@@ -1036,9 +1036,9 @@ > </table> > [% ELSE %] > <span class="noorder">There is no order for this bibliographic record.</span> >- [% END %] >- </div> >- [% END %] >+ [% END # /IF orders.count %] >+ </div> <!-- /.tab-pane#acq_details --> >+ [% END # /IF AcquisitionDetails %] > > [% IF suggestions.count %] > <div role="tabpanel" class="tab-pane" id="suggestion_details"> >@@ -1112,17 +1112,17 @@ > [% AuthorisedValues.GetByCode( 'SUGGEST_STATUS', suggestion.STATUS ) | html %] > [% ELSE %] > <span>Status unknown</span> >- [% END %] >+ [% END # /IF suggestion.STATUS %] > [% IF suggestion.reason %] > <br />([% suggestion.reason | html %]) > [% END %] > </td> > </tr> >- [% END %] >+ [% END # /FOREACH suggestion %] > </tbody> >- </table> >- </div> >- [% END %] >+ </table> <!-- /#suggestions --> >+ </div> <!-- /.tab-pane#suggestion_details --> >+ [% END # /IF suggestions.count %] > > [% IF ( FRBRizeEditions ) %] > [% IF ( XISBNS ) %] >@@ -1135,7 +1135,7 @@ > <td> > <a href="http://www.amazon.com/gp/reader/[% XISBN.normalized_isbn | uri %][% AmazonAssocTag | uri %]#reader-link"><img src="https://images-na.ssl-images-amazon.com/images/P/[% XISBN.normalized_isbn | html %].01._AA75_PU_PU-5_.jpg" /></a> > </td> >- [% END %] >+ [% END # /IF ( AmazonCoverImages ) %] > [% IF ( !item_level_itypes || Koha.Preference('BiblioItemtypeInfo') ) %] > <td> > [% IF ( noItemTypeImages ) %] >@@ -1144,7 +1144,7 @@ > <img src="[% XISBN.imageurl | html %]" alt="[% XISBN.description | html %]" title="[% XISBN.description | html %]"> > [% END %] > </td> >- [% END %] >+ [% END # /IF ( !item_level_itypes) %] > <td> > <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% XISBN.biblionumber | uri %]">[% XISBN.title | html %]</a> > <span>by</span> [% XISBN.author | html %] ©[% XISBN.copyrightdate | html %] >@@ -1155,11 +1155,11 @@ > [% IF ( XISBN.size ) %], [% END %][% XISBN.size | html %] > </td> > </tr> >- [% END %] >+ [% END # /FOREACH XISBN %] > </table> >- </div> >- [% END %] >- [% END %] >+ </div> <!-- /.tab-pane#editions --> >+ [% END # IF ( XISBNS ) %] >+ [% END # /IF ( FRBRizeEditions ) %] > > [% IF ( ( Koha.Preference('CatalogConcerns') || Koha.Preference('OpacCatalogConcerns') ) && CAN_user_editcatalogue_edit_catalogue ) %] > <div role="tabpanel" class="tab-pane" id="concerns"> >@@ -1177,9 +1177,9 @@ > <th data-class-name="actions noExport">Actions</th> > </tr> > </thead> >- </table> >- </div> >- [% END %] >+ </table> <!-- /#table_concerns --> >+ </div> <!-- /.tab-pane#concerns --> >+ [% END # /IF CatalogConcerns %] > > [% IF ( LocalCoverImages ) %] > <div role="tabpanel" class="tab-pane" id="images"> >@@ -1195,19 +1195,19 @@ > [% IF CAN_user_tools_upload_local_cover_images %] > <a href="#" class="remove"><i class="fa fa-trash"></i> Delete image</a> > [% END %] >- </li> >- [% END %] >- [% END %] >- </ul> >+ </li> <!-- /.thumbnail --> >+ [% END # /IF image %] >+ [% END # /FOREACH image %] >+ </ul> <!-- /.thumbnails --> > [% ELSE # - No image passed JavaScript takes care %] > <span class="noimagesuploaded">No images have been uploaded for this bibliographic record yet.</span> >- [% END %] >+ [% END # /IF localimages.count %] > [% IF ( CAN_user_tools_upload_local_cover_images ) %] > <p>Upload an image file: <a class="btn btn-default btn-xs" href="/cgi-bin/koha/tools/upload-cover-image.pl?biblionumber=[% biblionumber | uri %]&filetype=image"><i class="fa fa-upload" aria-hidden="true"></i> Upload</a> > </p> > [% END %] >- </div> >- [% END %] >+ </div> <!-- /.tab-pane#images --> >+ [% END # /IF ( LocalCoverImages ) %] > > [% IF ( HTML5MediaEnabled ) %] > <div role="tabpanel" class="tab-pane" id="html5media"> >@@ -1222,9 +1222,9 @@ > </[% HTML5MediaParent | html %]> > [% END %] > </p> >- [% END %] >- </div> >- [% END %] >+ [% END # /FOREACH HTML5MediaSet %] >+ </div> <!-- /.tab-pane#html5media --> >+ [% END # /IF ( HTML5MediaEnabled ) %] > > [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectStaffProfile') && Koha.Preference('NovelistSelectStaffView') == 'tab' ) %] > <div role="tabpanel" class="tab-pane" id="NovelistSelect" class="novelistSelect"> >@@ -1239,7 +1239,7 @@ > [% END %] > > </div><!-- /tab-content --> >- </div><!-- /bibliodetails --> >+ </div><!-- /#bibliodetails.toptabs --> > > <div id="export" style="margin-top: 1em;"> > <form method="get" action="/cgi-bin/koha/catalogue/export.pl"> >@@ -1267,7 +1267,7 @@ > </tr> > </table> > </form> >- </div> >+ </div> <!-- /#export --> > > <div id="marcPreview" class="modal" tabindex="-1" role="dialog" aria-labelledby="marcPreviewLabel" aria-hidden="true"> > <div class="modal-dialog modal-lg"> >@@ -1282,9 +1282,9 @@ > <div class="modal-footer"> > <button class="btn btn-default" data-dismiss="modal" aria-hidden="true">Close</button> > </div> >- </div> >- </div> >- </div> >+ </div> <!-- /.modal-content --> >+ </div> <!-- /.modal-dialog --> >+ </div> <!-- /#marcPreview --> > > <div id="elasticPreview" class="modal" tabindex="-1" role="dialog" aria-labelledby="elasticPreviewLabel" aria-hidden="true"> > <div class="modal-dialog modal-lg"> >@@ -1299,9 +1299,9 @@ > <div class="modal-footer"> > <button class="btn btn-default" data-dismiss="modal" aria-hidden="true">Close</button> > </div> >- </div> >- </div> >- </div> >+ </div> <!-- /.modal-content --> >+ </div> <!-- /.modal-dialog --> >+ </div> <!-- /#elasticPreview --> > </main> > </div> <!-- /.col-sm-10.col-sm-push-2 --> > >@@ -1340,10 +1340,10 @@ > <button id="modal-item-group-create-submit" class="btn btn-default"><i class="fa fa-plus"></i> Submit</button> > <button class="btn btn-link" data-dismiss="modal" aria-hidden="true">Cancel</button> > </div> >- </form> >- </div> >- </div> >- </div> >+ </form> <!-- /#modal-item-group-create-form --> >+ </div> <!-- /.modal-content --> >+ </div> <!-- /.modal-dialog --> >+ </div> <!-- /#modal-item-group-create --> > > <div class="modal fade" id="modal-item-group-edit" tabindex="-1" role="dialog" aria-labelledby="modal-item-group-edit-label"> > <div class="modal-dialog"> >@@ -1371,10 +1371,10 @@ > <button id="modal-item-group-edit-submit" class="btn btn-default"><i class='fa fa-edit'></i> Submit</button> > <button class="btn btn-link" data-dismiss="modal" aria-hidden="true">Cancel</button> > </div> >- </form> >- </div> >- </div> >- </div> >+ </form> <!-- /#modal-item-group-edit-form --> >+ </div> <!-- /.modal-content --> >+ </div> <!-- /.modal-dialog --> >+ </div> <!-- /#modal-item-group-edit --> > > <div class="modal fade" id="modal-item-group-delete" tabindex="-1" role="dialog" aria-labelledby="modal-item-group-delete-label"> > <div class="modal-dialog"> >@@ -1390,9 +1390,9 @@ > <button id="modal-item-group-delete-submit" class="btn btn-danger"><i class='fa fa-trash'></i> Delete</button> > <button class="btn btn-link" data-dismiss="modal" aria-hidden="true">Cancel</button> > </div> >- </div> >- </div> >- </div> >+ </div> <!-- /.modal-content --> >+ </div> <!-- /.modal-dialog --> >+ </div> <!-- /#modal-item-group-delete --> > > <div class="modal fade" id="modal-item-group-set" tabindex="-1" role="dialog" aria-labelledby="modal-item-group-set-label"> > <div class="modal-dialog"> >@@ -1419,10 +1419,10 @@ > <button id="modal-item-group-set-submit" class="btn btn-default"><i class='fa fa-book'></i> Set item group</button> > <button class="btn btn-link" data-dismiss="modal" aria-hidden="true">Cancel</button> > </div> >- </form> >- </div> >- </div> >- </div> >+ </form> <!-- /#modal-item-group-set-form --> >+ </div> <!-- /.modal-content --> >+ </div> <!-- /.modal-dialog --> >+ </div> <!-- /#modal-item-group-set --> > > <div class="modal fade" id="modal-item-group-unset" tabindex="-1" role="dialog" aria-labelledby="modal-item-group-unset-label"> > <div class="modal-dialog"> >@@ -1438,9 +1438,9 @@ > <button id="modal-item-group-unset-submit" class="btn btn-danger"><i class='fa fa-unlink'></i> Remove</button> > <button class="btn btn-link" data-dismiss="modal" aria-hidden="true">Cancel</button> > </div> >- </div> >- </div> >- </div> >+ </div> <!-- /.modal-content --> >+ </div> <!-- /.modal-dialog --> >+ </div> <!-- /#modal-item-group-unset --> > > [% IF bundlesEnabled %] > <div class="modal" id="addToBundleModal" tabindex="-1" role="dialog" aria-labelledby="addToBundleLabel"> >@@ -1467,10 +1467,10 @@ > <button type="submit" class="btn btn-default">Submit</button> > <button class="btn btn-default" data-dismiss="modal" aria-hidden="true">Close</button> > </div> >- </div> >- </div> >- </form> >- </div> >+ </div> <!-- /.modal-content --> >+ </div> <!-- /.modal-dialog --> >+ </form> <!-- /#addToBundleForm --> >+ </div> <!-- /#addToBundleModal --> > > <div class="modal" id="removeFromBundleModal" tabindex="-1" role="dialog" aria-labelledby="removeFromBundleLabel"> > <form id="removeFromBundleForm" action=""> >@@ -1496,11 +1496,11 @@ > <button type="submit" class="btn btn-default">Submit</button> > <button class="btn btn-default" data-dismiss="modal" aria-hidden="true">Close</button> > </div> >- </div> >- </div> >- </form> >- </div> >- [% END %] >+ </div> <!-- /.modal-content --> >+ </div> <!-- /.modal-dialog --> >+ </form> <!-- /#removeFromBundleForm --> >+ </div> <!-- /#removeFromBundleModal --> >+ [% END # /IF bundlesEnabled %] > > [% IF ( Koha.Preference('CatalogConcerns') ) %] > [% INCLUDE 'modals/add_catalog_concern.inc' %] >@@ -1524,9 +1524,9 @@ > var logged_in_user_borrowernumber = "[% logged_in_user.borrowernumber | html %]"; > </script> > [% Asset.js("js/modals/add_catalog_concern.js") | $raw %] >- [% END %] >- [% IF ( ( Koha.Preference('CatalogConcerns') || Koha.Preference('OpacCatalogConcerns') ) && CAN_user_editcatalogue_edit_catalogue ) %] >- <script> >+ [% END %] >+ [% IF ( ( Koha.Preference('CatalogConcerns') || Koha.Preference('OpacCatalogConcerns') ) && CAN_user_editcatalogue_edit_catalogue ) %] >+ <script> > $(document).ready(function() { > var table_settings = [% TablesSettings.GetTableSettings( 'cataloguing', 'concerns', 'table_concerns', 'json' ) | $raw %]; > >@@ -1637,7 +1637,7 @@ > }); > </script> > [% Asset.js("js/modals/display_ticket.js") | $raw %] >- [% END %] >+ [% END # /IF CatalogConcerns %] > <script> > var interface = "[% interface | html %]"; > var theme = "[% theme | html %]"; >@@ -1859,7 +1859,7 @@ > itemSelectionBuildActionLinks(tab); > }); > }); >- [% END %] >+ [% END # /IF StaffDetailItemSelection %] > > $(document).ready(function() { > // Pick details tab to display by default >@@ -1923,7 +1923,7 @@ > $(".NovelistSelect").show(); > } > }); >- [% END %] >+ [% END # /IF NovelistSelectStaffEnabled %] > $(".print-label").on("click", function(e){ > e.preventDefault(); > link = $(this).attr("href"); >@@ -1970,7 +1970,7 @@ > $(window).load(function() { > verify_cover_images(); > }); >- [% END %] >+ [% END # /IF IntranetCoce %] > </script> > [% IF ( Koha.Preference('NovelistSelectStaffEnabled') && Koha.Preference('NovelistSelectStaffProfile') && ( normalized_isbn || normalized_upc ) ) %] > <script src="https://imageserver.ebscohost.com/novelistselect/ns2init.js"></script> >@@ -2303,7 +2303,7 @@ > bundle_changed = 0; > }); > // End bundle handling >- [% END %] >+ [% END # /IF bundlesEnabled %] > > var table_names = [ 'holdings_table', 'otherholdings_table' ]; > var table_settings = [ [% TablesSettings.GetTableSettings('catalogue', 'detail','holdings_table','json') | $raw %], [% TablesSettings.GetTableSettings('catalogue', 'detail','otherholdings_table','json') | $raw %] ]; >@@ -2626,7 +2626,7 @@ > $('#modal-item-group-unset').modal('hide'); > > }); >- [% END %] >+ [% END # /IF EnableItemGroups %] > </script> > [% CoverImagePlugins | $raw %] > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33195
:
151432
|
151433
|
151486
|
167346
|
167347
|
167358
|
167359
|
168724
|
168725