Bugzilla – Attachment 151498 Details for
Bug 33789
Checkout information is missing when adding a credit
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33789: Return issue info. when adding a credit
Bug-33789-Return-issue-info-when-adding-a-credit.patch (text/plain), 1.71 KB, created by
Lucas Gass (lukeg)
on 2023-05-19 22:10:34 UTC
(
hide
)
Description:
Bug 33789: Return issue info. when adding a credit
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2023-05-19 22:10:34 UTC
Size:
1.71 KB
patch
obsolete
>From 69701f7903367e94ff89455888ed1a2bd47b0db2 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 19 May 2023 22:09:16 +0000 >Subject: [PATCH] Bug 33789: Return issue info. when adding a credit > >To test: >1. Make sure MarkLostItemsAsReturned is set so a lost item will stay on a patrons account after being marked as lost. >2. Check an item out to a patron, make sure it has a replacementprice >3. Mark the item as lost. >4. Now check the item in. >5. Go to the patrons account -> transaction tab. You should see 2 accountlines related to the item. >6. For the account type 'Lost item' you will see issue infomation ( check out date, due date, checkouted out from, etc ) >7. For the account type 'Lost item fee refund' there is no issue information. >8. Apply patch >9. Try 2 - 6 again. This time the 'Lost item fee refund' should include issue information. >--- > Koha/Account.pm | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/Koha/Account.pm b/Koha/Account.pm >index 6d0c42f989..13611dc0c3 100644 >--- a/Koha/Account.pm >+++ b/Koha/Account.pm >@@ -210,6 +210,7 @@ sub add_credit { > my $payment_type = $params->{payment_type}; > my $credit_type = $params->{type} || 'PAYMENT'; > my $item_id = $params->{item_id}; >+ my $issue_id = $params->{issue_id}; > > Koha::Exceptions::Account::RegisterRequired->throw() > if ( C4::Context->preference("UseCashRegisters") >@@ -239,6 +240,7 @@ sub add_credit { > branchcode => $library_id, > register_id => $cash_register, > itemnumber => $item_id, >+ issue_id => $issue_id, > } > )->store(); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33789
:
151498
|
151528
|
151650
|
151897
|
151898
|
152014