Attachment 15153 Details for Bug 9451 – Bug 9451: Quiet warnings and Plackify borrower_stats.pl

[patch] Bug 9451: Quiet warnings and Plackify borrower_stats.pl

Bug-9451-Quiet-warnings-and-Plackify-borrowerstats.patch (text/plain), 1.85 KB, created by Chris Cormack on 2013-02-08 08:28:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2013-02-08 08:28:57 UTC

Size: 1.85 KB

patch

obsolete

>From 03b8069094f82ae18a3f7cde00b8cf2083f60fc2 Mon Sep 17 00:00:00 2001
>From: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Date: Tue, 22 Jan 2013 18:40:25 -0500
>Subject: [PATCH] Bug 9451: Quiet warnings and Plackify borrower_stats.pl
>
>There are several warnings and one non-Plack-compatible variable in
>reports/borrower_stats.pl.
>
>To test:
>1) Apply patch
>2) Use the borrower report wizard to create a report that includes an
>   extended patron attribute.
>3) Check the logs, and make sure that you don't see any of the
>   following messages:
>   Variable "$period" is not available at
>     /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265.
>   Use of uninitialized value in hash element at
>     /home/jcamins/kohaclone/reports/borrowers_stats.pl line 375.
>   Use of uninitialized value in hash element at
>     /home/jcamins/kohaclone/reports/borrowers_stats.pl line 376.
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>---
> reports/borrowers_stats.pl |    3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/reports/borrowers_stats.pl b/reports/borrowers_stats.pl
>index 9454fc5..8181285 100755
>--- a/reports/borrowers_stats.pl
>+++ b/reports/borrowers_stats.pl
>@@ -56,7 +56,7 @@ my @filters = $input->param("Filter");
> $filters[3]=format_date_in_iso($filters[3]);
> $filters[4]=format_date_in_iso($filters[4]);
> my $digits = $input->param("digits");
>-my $period = $input->param("period");
>+our $period = $input->param("period");
> my $borstat = $input->param("status");
> my $borstat1 = $input->param("activity");
> my $output = $input->param("output");
>@@ -372,6 +372,7 @@ sub calculate {
>             my $coltitle = $row->{coltitle} // '';
>             $table{$rowtitle}->{$coltitle} = 0;
> 		}
>+        $row->{rowtitle} ||= '';
> 		$table{$row->{rowtitle}}->{totalrow}=0;
> 		$table{$row->{rowtitle}}->{rowtitle_display} = $row->{rowtitle_display};
> 	}
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 9451: 14763 | 15153 | 15157