Attachment 151542 Details for Bug 32464 – Bug 32464: Koha::Item->as_marc_field obsolete option mss

[patch] Bug 32464: Koha::Item->as_marc_field obsolete option mss

Bug-32464-KohaItem-asmarcfield-obsolete-option-mss.patch (text/plain), 1.35 KB, created by Nick Clemens (kidclamp) on 2023-05-22 18:33:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2023-05-22 18:33:57 UTC

Size: 1.35 KB

patch

obsolete

>From cf797ff4a66b4871de9491644514b79139b4781d Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Tue, 13 Dec 2022 11:24:54 -1000
>Subject: [PATCH] Bug 32464: Koha::Item->as_marc_field obsolete option mss
>
>Since Bug 28445 the method Koha::Item->as_marc_field has the option mss not anymore.
>
>This patch removes this in Koha::Filter::MARC::EmbedItems.
>
>Test with :
>prove t/db_dependent/Koha/Filter/EmbedItems.t
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> Koha/Filter/MARC/EmbedItems.pm | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/Koha/Filter/MARC/EmbedItems.pm b/Koha/Filter/MARC/EmbedItems.pm
>index 2839694ff8..e3e316e295 100644
>--- a/Koha/Filter/MARC/EmbedItems.pm
>+++ b/Koha/Filter/MARC/EmbedItems.pm
>@@ -71,13 +71,11 @@ sub filter {
>     return unless defined $record and ref($record) eq 'MARC::Record';
> 
>     my $items = $self->{params}->{options}->{items};
>-    my $mss   = $self->{params}->{options}->{mss}
>-      // C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } );
> 
>     my @item_fields;
> 
>     foreach my $item ( @{$items} ) {
>-        push @item_fields, $item->as_marc_field( { mss => $mss } );
>+        push @item_fields, $item->as_marc_field;
>     }
> 
>     $record->append_fields(@item_fields);
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32464: 144558 | 144604 | 144608 | 151542 | 151543