Attachment 151606 Details for Bug 33809 – Bug 33809: Facet "Show more/less" links don't identify what they are showing

[patch] Bug 33809: Facet "Show more/less" links don't identify what they are showing

Bug-33809-Facet-Show-moreless-links-dont-identify-.patch (text/plain), 5.20 KB, created by Lucas Gass (lukeg) on 2023-05-23 21:05:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-05-23 21:05:54 UTC

Size: 5.20 KB

patch

obsolete

>From 455500ca6a4d63081b2c527c26a2432da90ff06e Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Tue, 23 May 2023 14:13:03 +0000
>Subject: [PATCH] Bug 33809: Facet "Show more/less" links don't identify what
> they are showing
>
>This patch addresses the Show more/less links in the side menu in opac-facets.inc. The links don't identify which facet they are linked to and this is confusing for screen readers.
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../bootstrap/en/includes/opac-facets.inc | 28 +++++++++++++++++--
> 1 file changed, 26 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>index 844de90853..2b60c384b7 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>@@ -85,10 +85,34 @@
> [% END %]
> [% IF facets_loo.facets.size > 5 %]
> <li class="moretoggle">
>- <a href="#">Show more</a>
>+ [% IF facets_loo.type_label_Authors %]<a href="#" aria-label="Show more authors">Show more</a>[% END %]
>+ [% IF facets_loo.type_label_Titles %]<a href="#" aria-label="Show more titles">Show more</a>[% END %]
>+ [% IF facets_loo.type_label_Topics %]<a href="#" aria-label="Show more topics">Show more</a>[% END %]
>+ [% IF facets_loo.type_label_Places %]<a href="#" aria-label="Show more places">Show more</a>[% END %]
>+ [% IF facets_loo.type_label_Series %]<a href="#" aria-label="Show more series">Show more</a>[% END %]
>+ [% IF facets_loo.type_label_ItemTypes %]<a href="#" aria-label="Show more item types">Show more</a>[% END %]
>+ [% IF facets_loo.type_label_CollectionCodes %]<a href="#" aria-label="Show more collection codes">Show more</a>[% END %]
>+ [% IF facets_loo.type_label_Language %]<a href="#" aria-label="Show more languages">Show more</a>[% END %]
>+ [% UNLESS singleBranchMode %]
>+ [% IF ( facets_loo.type_label_HomeLibrary ) %]<a href="#" aria-label="Show more home libraries">Show more</a>[% END %]
>+ [% IF ( facets_loo.type_label_HoldingLibrary ) %]<a href="#" aria-label="Show more holding libraries">Show more</a>[% END %]
>+ [% END %]
>+ [% IF facets_loo.type_label_Location %]<a href="#" aria-label="Show more locations">Show more</a>[% END %]
> </li>
> <li class="moretoggle" style="display:none">
>- <a href="#">Show less</a>
>+ [% IF facets_loo.type_label_Authors %]<a href="#" aria-label="Show less authors">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_Titles %]<a href="#" aria-label="Show less titles">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_Topics %]<a href="#" aria-label="Show less topics">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_Places %]<a href="#" aria-label="Show less places">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_Series %]<a href="#" aria-label="Show less series">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_ItemTypes %]<a href="#" aria-label="Show less item types">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_CollectionCodes %]<a href="#" aria-label="Show less collection codes">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_Language %]<a href="#" aria-label="Show less languages">Show less</a>[% END %]
>+ [% UNLESS singleBranchMode %]
>+ [% IF ( facets_loo.type_label_HomeLibrary ) %]<a href="#" aria-label="Show less home libraries">Show less</a>[% END %]
>+ [% IF ( facets_loo.type_label_HoldingLibrary ) %]<a href="#" aria-label="Show less holding libraries">Show less</a>[% END %]
>+ [% END %]
>+ [% IF facets_loo.type_label_Location %]<a href="#" aria-label="Show less locations">Show less</a>[% END %]
> </li>
> [% END %]
> </ul>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33809: 151568 | 151569 | 151576 | 151606 | 151607 | 151925 | 152050 | 153121 | 157986 | 157987 | 157988 | 157989