Attachment 151607 Details for Bug 33809 – Bug 33809: Place hold and Add to cart links need better descriptions

[patch] Bug 33809: Place hold and Add to cart links need better descriptions

Bug-33809-Place-hold-and-Add-to-cart-links-need-be.patch (text/plain), 4.51 KB, created by Lucas Gass (lukeg) on 2023-05-23 21:05:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-05-23 21:05:57 UTC

Size: 4.51 KB

patch

obsolete

>From d47418e0ac7cb45e5410522486591b4f4f17bea6 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Tue, 23 May 2023 14:15:30 +0000
>Subject: [PATCH] Bug 33809: Place hold and Add to cart links need better
> descriptions
>
>The place hold and add to cart buttons should identify to screen readers which title the button is linked to. This patch adds aria-labels that include the item title to make this more clear
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../bootstrap/en/includes/title-actions-menu.inc | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc
>index 9f1fb2015e..bfcfd7a6cb 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc
>@@ -4,14 +4,14 @@
> [% IF Koha.Preference( 'opacuserlogin' ) == 1 %]
> [% IF ( shelf AND op == 'view' ) # Lists view has more granular checking of hold availability %]
> [% IF ( items.allow_onshelf_holds ) %]
>- <a class="btn btn-link btn-sm" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"> Place hold</a>
>+ <a class="btn btn-link btn-sm" aria-label="Place a hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"> Place hold</a>
> [% ELSE %]
> [% IF ( items.itemsissued ) %]
>- <a class="btn btn-link btn-sm" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"> Place hold</a>
>+ <a class="btn btn-link btn-sm" aria-label="Place a hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"> Place hold</a>
> [% END %]
> [% END %]
> [% ELSE %]
>- <a class="btn btn-link btn-sm" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"> Place hold</a>
>+ <a class="btn btn-link btn-sm" aria-label="Place a hold on [% items.title | html %]" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% items.biblionumber | html %]"> Place hold</a>
> [% END %]
> [% END # / IF opacuserlogin %]
> [% END # / UNLESS items.norequests %]
>@@ -63,7 +63,7 @@
> [% IF ( items.incart ) %]
> <a data-biblionumber="[% items.biblionumber | html %]" class="btn btn-link btn-sm addtocart cart[% items.biblionumber | html %]" href="#"> In your cart</a> <a data-biblionumber="[% items.biblionumber | html %]" class="btn btn-link btn-sm remove cartRemove cartR[% items.biblionumber | html %]" href="#">(remove)</a>
> [% ELSE %]
>- <a data-biblionumber="[% items.biblionumber | html %]" class="btn btn-link btn-sm addtocart cart cart[% items.biblionumber | html %]" href="#"> Add to cart</a> <a style="display:none;" data-biblionumber="[% items.biblionumber | html %]" class="btn btn-link btn-sm remove cartRemove cartR[% items.biblionumber | html %]" href="#">(remove)</a>
>+ <a aria-label="Add [% items.title | html %] to the cart" data-biblionumber="[% items.biblionumber | html %]" class="btn btn-link btn-sm addtocart cart cart[% items.biblionumber | html %]" href="#"> Add to cart</a> <a style="display:none;" data-biblionumber="[% items.biblionumber | html %]" class="btn btn-link btn-sm remove cartRemove cartR[% items.biblionumber | html %]" href="#">(remove)</a>
> [% END %]
> [% END # / IF opacbookbag %]
> </div>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33809: 151568 | 151569 | 151576 | 151606 | 151607 | 151925 | 152050 | 153121 | 157986 | 157987 | 157988 | 157989