Attachment 151618 Details for Bug 33810 – Bug 33810: Opac advanced search fields need aria-labels

[patch] Bug 33810: Opac advanced search fields need aria-labels

Bug-33810-Opac-advanced-search-fields-need-aria-la.patch (text/plain), 2.38 KB, created by Matt Blenkinsop on 2023-05-24 09:34:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2023-05-24 09:34:04 UTC

Size: 2.38 KB

patch

obsolete

>From 7c9b9105295b648f5e1546dc5eff89718a906abd Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Tue, 23 May 2023 14:49:08 +0000
>Subject: [PATCH] Bug 33810: Opac advanced search fields need aria-labels
>
>The OPAC advanced search fields need aria-labels to assist with screen reading. This patch adds labels to both the dropdown selects and the text inputs
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>index 7e09f3911f..02a0de711a 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
>@@ -57,7 +57,7 @@
>                                         </div> 
> 
>                                         <div class="search-term-input">
>-                                            <select class="form-control" name="idx" id="search-field_[% loop.index | html %]">
>+                                            <select class="form-control" name="idx" aria-label="Choose search type for field [% loop.index + 1 | html %]" id="search-field_[% loop.index | html %]">
>                                                 <option value="kw">Keyword</option>
>                                                 [% IF ( expanded_options ) %]
>                                                     <option value="kw,phr">&nbsp;&nbsp;&nbsp;&nbsp; Keyword phrase</option>
>@@ -112,7 +112,7 @@
>                                             </select> 
>                                         </div> 
>                                         <div class="search-term-input">
>-                                            <input class="form-control" type="text" size="" name="q" title="Enter search terms" value="" />
>+                                            <input class="form-control" type="text" size="" name="q" aria-label="Enter field [% loop.index + 1 | html %] search terms" value="" />
>                                         </div> 
>                                         [% IF ( expanded_options ) %]
>                                             <div class="search-term-input">
>-- 
>2.37.1 (Apple Git-137.1)

Actions: View | Diff | Splinter Review

Attachments on bug 33810: 151577 | 151618 | 154493 | 154498 | 157579