Bugzilla – Attachment 151653 Details for
Bug 33734
Using custom search filters breaks diacritics characters in search term
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33734: Use raw filters with search filter links in facets.inc
Bug-33734-Use-raw-filters-with-search-filter-links.patch (text/plain), 2.12 KB, created by
Sam Lau
on 2023-05-24 20:03:52 UTC
(
hide
)
Description:
Bug 33734: Use raw filters with search filter links in facets.inc
Filename:
MIME Type:
Creator:
Sam Lau
Created:
2023-05-24 20:03:52 UTC
Size:
2.12 KB
patch
obsolete
>From 29beb62cd436af016dcb184a5943aa3577f1542c Mon Sep 17 00:00:00 2001 >From: Ville Korjus <trainee@koha-suomi.fi> >Date: Tue, 23 May 2023 10:10:05 +0300 >Subject: [PATCH] Bug 33734: Use raw filters with search filter links in > facets.inc >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Using html filters breaks scandic characters in search term >if one uses custom search filters. Use raw filters instead. > >To test: >1. Enable SavedSearchFilters syspref >2. Perform search with bib-level:("a") >3. Click "Save search as filter" and save >4. Perform search containing scandic character (åöä) >5. Use filter you just created >=> notice that scandic characters in search term are displayed >incorrectly e.g. ä turns to ä >6. Apply this patch >7. Repeat steps 4 and 5 >=> scandic characters should now be displayed correctly > >Sponsored-by: Koha-Suomi Oy >Signed-off-by: Sam Lau <samalau@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >index 2c56036f04..dcd17b1dee 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc >@@ -15,9 +15,9 @@ > [% FOREACH search_filter IN search_filters %] > <li> > [% IF active_filters.${search_filter.id} %] >- <span class="filter_label">[% search_filter.name | html %]<a href="[% base_url _ '&nolimit=search_filter:' _ search_filter.id | url %]">[x]</a></span> >+ <span class="filter_label">[% search_filter.name | html %]<a href="[% base_url _ '&nolimit=search_filter:' _ search_filter.id | $raw %]">[x]</a></span> > [% ELSE %] >- <span class="filter_label"><a href="[% base_url _ '&limit=search_filter:' _ search_filter.id | url %]">[% search_filter.name | html %]</a></span> >+ <span class="filter_label"><a href="[% base_url _ '&limit=search_filter:' _ search_filter.id | $raw %]">[% search_filter.name | $raw %]</a></span> > [% END %] > </li> > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33734
:
151551
|
151653
|
155582
|
155583
|
155584
|
155585
|
155690