Attachment 151690 Details for Bug 33833 – Bug 33833: Add two FIXMEs to SocialData::get_report

[patch] Bug 33833: Add two FIXMEs to SocialData::get_report

Bug-33833-Add-two-FIXMEs-to-SocialDatagetreport.patch (text/plain), 1.32 KB, created by Owen Leonard on 2023-05-25 14:48:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-05-25 14:48:37 UTC

Size: 1.32 KB

patch

obsolete

>From bfea44060069ad5a3bf97c36daad1b1e26cc6b11 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 22 May 2023 08:46:31 +0000
>Subject: [PATCH] Bug 33833: Add two FIXMEs to SocialData::get_report
>
>Just comments, no test plan.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> C4/SocialData.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/SocialData.pm b/C4/SocialData.pm
>index 8217ccb49e..8a9c123529 100644
>--- a/C4/SocialData.pm
>+++ b/C4/SocialData.pm
>@@ -120,7 +120,7 @@ sub get_report {
> 
>     my $sth = $dbh->prepare( qq{
>         SELECT biblionumber, isbn FROM biblioitems
>-    } );
>+    } ); # FIXME We could better join socialdata here than call get_data for each record?
>     $sth->execute;
>     my %results;
>     while ( my ( $biblionumber, $isbn ) = $sth->fetchrow() ) {
>@@ -135,7 +135,7 @@ sub get_report {
>         };
>         next if $@;
>         $isbn =~ s/-//g;
>-        my $social_datas = C4::SocialData::get_data( $isbn );
>+        my $social_datas = C4::SocialData::get_data( $isbn ); # FIXME Why is data not included in $results ?
>         if ( $social_datas ) {
>             push @{ $results{with} }, { biblionumber => $biblionumber, isbn => $isbn, original => $original_isbn };
>         } else {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33833: 151679 | 151680 | 151681 | 151682 | 151689 | 151690 | 151691 | 155091 | 155092 | 155093