Attachment 151692 Details for Bug 33829 – Bug 33829: Fix add patron to patron list if PatronAutoComplete is off

[patch] Bug 33829: Fix add patron to patron list if PatronAutoComplete is off

Bug-33829-Fix-add-patron-to-patron-list-if-PatronA.patch (text/plain), 1.63 KB, created by Lucas Gass (lukeg) on 2023-05-25 14:50:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-05-25 14:50:19 UTC

Size: 1.63 KB

patch

obsolete

>From fd1cdebee15588f1e483c83a7feb0a68d05cf4d3 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 25 May 2023 15:07:25 +0200
>Subject: [PATCH] Bug 33829: Fix add patron to patron list if
> PatronAutoComplete is off
>
>When adding patrons to a patron list we get a JS error about undefined
>variables. We can easily fix this problem by defining them even if the
>pref is not set.
>
>We are enabling the auto complete even if PatronAutoComplete if off.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
>index a2ba59bf31..f1745d52e8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
>@@ -69,12 +69,14 @@
>     </script>
> [% END %]
> 
>-[% IF ( PatronAutoComplete ) %]
>-    <script>
>-    // PatronAutoComplete
>+<script>
>     var defaultPatronSearchFields = "[% Koha.Preference('DefaultPatronSearchFields') || 'firstname,middle_name,surname,othernames,cardnumber,userid' | html %]";
>     var loggedInLibrary = '[% Branches.GetLoggedInBranchcode | html %]';
>     var singleBranchMode = '[% singleBranchMode | html %]';
>+</script>
>+[% IF ( PatronAutoComplete ) %]
>+    <script>
>+    // PatronAutoComplete
>     var loggedInClass = "";
>     $(document).ready(function(){
>         [% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33829: 151676 | 151687 | 151692