Bugzilla – Attachment 151704 Details for
Bug 33838
Offline circulation interface error on return
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33838: Don't reset the renewal count
Bug-33838-Dont-reset-the-renewal-count.patch (text/plain), 803 bytes, created by
Kyle M Hall (khall)
on 2023-05-25 17:02:18 UTC
(
hide
)
Description:
Bug 33838: Don't reset the renewal count
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2023-05-25 17:02:18 UTC
Size:
803 bytes
patch
obsolete
>From ae11c7b8214bbf9552667b081fc0776528db52da Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 25 May 2023 12:57:24 -0400 >Subject: [PATCH] Bug 33838: Don't reset the renewal count > >I cannot find any justification for this line existing. >MarkIssueReturned does not do this. >--- > C4/Circulation.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 74d23db32c..ecd969235a 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -4079,7 +4079,6 @@ sub ProcessOfflineReturn { > $itemnumber, > $operation->{timestamp}, > ); >- $item->renewals_count(0); > $item->onloan(undef); > $item->store({ log_action => 0 }); > return "Success."; >-- >2.30.2
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=151704">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33838
:
151700
|
151704
|
151705
|
151706
|
151787
|
151792