Attachment 151706 Details for Bug 33838 – Bug 33838: Don't reset the renewal count

[patch] Bug 33838: Don't reset the renewal count

Bug-33838-Dont-reset-the-renewal-count.patch (text/plain), 1.47 KB, created by Andrew Fuerste-Henry on 2023-05-25 17:53:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Fuerste-Henry

Created: 2023-05-25 17:53:04 UTC

Size: 1.47 KB

patch

obsolete

>From c0a243ec7da6de97ea708e29d2b10cc526f9e295 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 25 May 2023 12:57:24 -0400
>Subject: [PATCH] Bug 33838: Don't reset the renewal count
>
>I cannot find any justification for this line existing.
>MarkIssueReturned does not do this.
>
>Resetting item's renewal count was introduced in bug 5877 with no explanation.
>
>Test Plan:
>1) Check out item 3999900000001 to a patron
>2) Upload the KOC file attached to this bug report
>3) Navigate the Pending Offline Circ actions, see your return is listed
>4) Click the checkbox to select your return
>5) Click Process once. Nothing appears to happen
>6) In a new tab, pull up the bib for item 3999900000001, see that it has been checked in
>7) Back on your Offline Circ tab, click Process a second time
>8) Koha tells you the item is not checked out
>9) Apply this patch, restart all the things!
>10) Repeat steps 1-4, everything should now work!
>
>Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
>---
> C4/Circulation.pm | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 74d23db32c..ecd969235a 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -4079,7 +4079,6 @@ sub ProcessOfflineReturn {
>                 $itemnumber,
>                 $operation->{timestamp},
>             );
>-            $item->renewals_count(0);
>             $item->onloan(undef);
>             $item->store({ log_action => 0 });
>             return "Success.";
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33838: 151700 | 151704 | 151705 | 151706 | 151787 | 151792