Bugzilla – Attachment 15175 Details for
Bug 9571
Fix width for textareas in Edit Item screen
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 9571 [Alternate] Fix width for textareas in Edit Item screen
Bug-9571-Alternate-Fix-width-for-textareas-in-Edit.patch (text/plain), 2.16 KB, created by
Kyle M Hall (khall)
on 2013-02-08 16:50:24 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 9571 [Alternate] Fix width for textareas in Edit Item screen
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-02-08 16:50:24 UTC
Size:
2.16 KB
patch
obsolete
>From b60d50f1f3d8ff95a78a47e6cf1db71c84bf5292 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 8 Feb 2013 11:21:11 -0500 >Subject: [PATCH] Bug 9571 [Alternate] Fix width for textareas in Edit Item screen > >This alternative patch modifies the script where the input markup is >built and adds an alternative configuration for textareas. This gives >the textareas explicit "cols" and "rows" attributes. I think this >solution is preferable to a style fix because it solves the bug while >eliminating some invalid markup (no "size" or "maxlength" attributes on >textareas, which are invalid without explicit dimensions). > >To test, add a nice big chunk of text to an existing item's item field >like "Public note" (952$z), save, and edit again. The field should now >be displayed in a more comfortably-sized textarea. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > cataloguing/additem.pl | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index 1bd19a7..4d6a583 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -154,6 +154,7 @@ sub generate_subfield_form { > $value = $input->param('barcode'); > } > my $attributes_no_value = qq(tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" size="67" maxlength="$subfield_data{maxlength}" ); >+ my $attributes_no_value_textarea = qq(tabindex="1" id="$subfield_data{id}" name="field_value" class="input_marceditor" rows="5" cols="64" ); > my $attributes = qq($attributes_no_value value="$value" ); > > if ( $subfieldlib->{authorised_value} ) { >@@ -270,7 +271,7 @@ sub generate_subfield_form { > 500 <= $tag && $tag < 600 ) > ) { > # oversize field (textarea) >- $subfield_data{marc_value} = "<textarea $attributes_no_value>$value</textarea>\n"; >+ $subfield_data{marc_value} = "<textarea $attributes_no_value_textarea>$value</textarea>\n"; > } else { > # it's a standard field > $subfield_data{marc_value} = "<input type=\"text\" $attributes />"; >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9571
:
15152
|
15173
|
15174
| 15175 |
16834