Bugzilla – Attachment 151752 Details for
Bug 27378
Enable compliance with EU Cookie Legislation via cookie consent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27378: Prevent delete confirmation from duplicating
Bug-27378-Prevent-delete-confirmation-from-duplica.patch (text/plain), 2.36 KB, created by
Matt Blenkinsop
on 2023-05-26 12:19:07 UTC
(
hide
)
Description:
Bug 27378: Prevent delete confirmation from duplicating
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2023-05-26 12:19:07 UTC
Size:
2.36 KB
patch
obsolete
>From 144e91fc256d13b659a9804c687f4bd9d3bc9272 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Thu, 25 May 2023 15:58:26 +0000 >Subject: [PATCH] Bug 27378: Prevent delete confirmation from duplicating > >Previously, if the "Add new code" button was clicked multipe times in the CookieConsentedJS editor and then those new items were deleted, the confirmation alert would show multiple times. >This was an incremental issue, i.e. if 4 new items were deleted, then the first of those would require 4 confirmations to delete, the second would require 3 and so on. >This is now prevented by looping through all delete buttons and avoiding duplicating the event listeners >--- > .../prog/js/pages/preferences.js | 29 +++++++++++-------- > 1 file changed, 17 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js >index 6bde33bba4..fc72beff92 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js >@@ -134,19 +134,24 @@ function addCollapseHandler() { > > // Add a handler for any consent delete links > function addConsentDeleteHandler() { >- // Don't duplicate click event handlers >- const ev = $._data($('.consentDelete'), 'events'); >- if (ev && ev.click) { >- return; >- } >- $('.consentDelete').on('click', function (e) { >- e.preventDefault(); >- const target = $(this).data('target'); >- const proceed = confirm(__('Are you sure you want to delete this consent item?')); >- if (proceed) { >- $('#' + target).remove(); >+ const deleteButtons = $('.consentDelete').map(function() { >+ return this >+ }).get(); >+ deleteButtons.forEach((deleteButton) => { >+ // Don't duplicate click event handlers >+ const ev = $._data($(deleteButton).get(0), 'events'); >+ if (ev && ev.click) { >+ return; > } >- }); >+ $(deleteButton).on('click', function (e) { >+ e.preventDefault(); >+ const target = $(this).data('target'); >+ const proceed = confirm(__('Are you sure you want to delete this consent item?')); >+ if (proceed) { >+ $('#' + target).remove(); >+ } >+ }); >+ }) > } > > $( document ).ready( function () { >-- >2.37.1 (Apple Git-137.1)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27378
:
115544
|
115545
|
115546
|
115547
|
115548
|
115756
|
116397
|
116398
|
116399
|
116400
|
116401
|
116402
|
116403
|
116416
|
116417
|
116418
|
116419
|
116420
|
116421
|
116422
|
116423
|
116978
|
116979
|
116980
|
116981
|
116982
|
116983
|
116984
|
116985
|
116986
|
121728
|
121729
|
121730
|
121731
|
121732
|
121733
|
121734
|
121735
|
121995
|
121996
|
121997
|
121998
|
121999
|
122000
|
122001
|
122002
|
122635
|
122636
|
122637
|
122638
|
122639
|
122640
|
122641
|
122642
|
124957
|
124958
|
124959
|
124960
|
124961
|
124962
|
124963
|
124964
|
124965
|
130072
|
130073
|
130074
|
130075
|
130076
|
130077
|
130078
|
130079
|
130080
|
135309
|
135310
|
135311
|
135312
|
135313
|
135314
|
135315
|
135316
|
135317
|
135318
|
151735
|
151736
|
151737
|
151738
|
151739
|
151740
|
151741
|
151742
|
151743
|
151744
|
151745
|
151746
|
151747
|
151748
|
151749
|
151750
|
151751
|
151752
|
151753
|
151826
|
151827
|
151828
|
151829
|
151830
|
151831
|
151832
|
151833
|
151834
|
151835
|
151836
|
151837
|
151838
|
151839
|
151840
|
151841
|
151842
|
151843
|
151844
|
153326
|
153327
|
153328
|
153329
|
153330
|
153331
|
153332
|
153333
|
153334
|
153335
|
153336
|
154015
|
154016
|
154017
|
154018
|
154019
|
154020
|
154021
|
154022
|
154023
|
154024
|
154025
|
154093
|
154264
|
154265
|
154266
|
154267
|
154268
|
154269
|
154270
|
154271
|
154272
|
154273
|
154274
|
154275
|
154276