Attachment 151785 Details for Bug 33844 – Bug 33844: Modify test to show problem

[patch] Bug 33844: Modify test to show problem

Bug-33844-Modify-test-to-show-problem.patch (text/plain), 1.41 KB, created by Katrin Fischer on 2023-05-29 17:15:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-05-29 17:15:48 UTC

Size: 1.41 KB

patch

obsolete

>From 8ce08c08841f1166dd306b135f8233fa4a77bc8c Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 26 May 2023 12:54:22 +0000
>Subject: [PATCH] Bug 33844: Modify test to show problem
>
>Add delete key.
>Without the follow-up, this triggers a delete. Test fails.
>DBIx::Class::Row::delete(): Not in database at /usr/share/koha/Koha/Object.pm line 234
>
>Test plan:
>Run t/db_dependent/Koha/Item.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> t/db_dependent/Koha/Item.t | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t
>index 6066c752bc..c22c782fe6 100755
>--- a/t/db_dependent/Koha/Item.t
>+++ b/t/db_dependent/Koha/Item.t
>@@ -2143,7 +2143,8 @@ subtest 'is_denied_renewal' => sub {
>     C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules);
>     is( $deny_book->is_denied_renewal, 0, 'Renewal allowed when no rules' );
> 
>-    $idr_rules="withdrawn: [1]";
>+    # The wrong column delete should be silently ignored and not trigger item delete
>+    $idr_rules="delete: [yes]\nwithdrawn: [1]";
>     C4::Context->set_preference('ItemsDeniedRenewal', $idr_rules);
>     is( $deny_book->is_denied_renewal, 1, 'Renewal blocked when 1 rules (withdrawn)' );
>     is( $allow_book->is_denied_renewal, 0, 'Renewal allowed when 1 rules not matched (withdrawn)' );
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33844: 151759 | 151760 | 151785 | 151786 | 152110 | 152111