Bugzilla – Attachment 151949 Details for
Bug 33876
item-note-nonpublic and item-note-public are difficult to customize in the checkout table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33876: Add class for styling
Bug-33876-Add-class-for-styling.patch (text/plain), 2.70 KB, created by
Sam Lau
on 2023-06-01 16:20:58 UTC
(
hide
)
Description:
Bug 33876: Add class for styling
Filename:
MIME Type:
Creator:
Sam Lau
Created:
2023-06-01 16:20:58 UTC
Size:
2.70 KB
patch
obsolete
>From 99823662756601943cad5b01cf4505562fbd4639 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 31 May 2023 22:38:50 +0000 >Subject: [PATCH] Bug 33876: Add class for styling > >To test: >1. Checkout and item that has a public and nonpublic note. >2. In the checkout table ( Title column ) notice the notes display. If you use the browser dev tools to inspect you'll notice a "-" outside of any HTML element. >3. Apply patch. >4. See the '-' is now inside of a html element with class of seperator. > >Signed-off-by: Sam Lau <samalau@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index 534fec1cda..bf039dad20 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -350,7 +350,7 @@ $(document).ready(function() { > if ( flatpickr.formatDate( new Date(oObj.issuedate), "Y-m-d" ) == ymd ){ > span_class = "circ-hlt"; > } >- title += " - <span class='" + span_class + " item-note-public'>" + oObj.itemnotes.escapeHtml() + "</span>"; >+ title += "<span class='seperator'> - </span><span class='" + span_class + " item-note-public'>" + oObj.itemnotes.escapeHtml() + "</span>"; > } > > if ( oObj.itemnotes_nonpublic ) { >@@ -358,7 +358,7 @@ $(document).ready(function() { > if ( flatpickr.formatDate( new Date(oObj.issuedate), "Y-m-d" ) == ymd ){ > span_class = "circ-hlt"; > } >- title += " - <span class='" + span_class + " item-note-nonpublic'>" + oObj.itemnotes_nonpublic.escapeHtml() + "</span>"; >+ title += "<span class='seperator'> - </span><span class='" + span_class + " item-note-nonpublic'>" + oObj.itemnotes_nonpublic.escapeHtml() + "</span>"; > } > > var onsite_checkout = ''; >@@ -367,7 +367,7 @@ $(document).ready(function() { > } > > if ( oObj.recalled == 1 ) { >- title += " - <span class='circ-hlt item-recalled'>" + __("This item has been recalled and the due date updated") + ".</span>"; >+ title += "<span class='seperator'> - </span><span class='circ-hlt item-recalled'>" + __("This item has been recalled and the due date updated") + ".</span>"; > } > > title += " " >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33876
:
151891
|
151949
|
152326
|
155381