Attachment 151955 Details for Bug 22135 – Bug 22135: Display 'shelved out of order' error in inventory CSV export

[patch] Bug 22135: Display 'shelved out of order' error in inventory CSV export

Bug-22135-Display-shelved-out-of-order-error-in-in.patch (text/plain), 2.31 KB, created by David Nind on 2023-06-01 22:31:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-06-01 22:31:34 UTC

Size: 2.31 KB

patch

obsolete

>From 7c7511d76853ec291ef90db243fca2eecc7e2492 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Mon, 29 May 2023 15:41:44 +0000
>Subject: [PATCH] Bug 22135: Display 'shelved out of order' error in inventory
> CSV export
>
>When using the inventory tool with an uploaded barcode file
>and checking the "Compare barcodes list to results",
>"Check barcodes list for items shelved out of order" and
>"Export to CSV file" checkboxes, the resulting CSV file showed
>a blank in the "problem" column for items with out of order
>callnumbers. With this patch, you'll see "Shelved out of order".
>
>To test:
>* Create 3 items with callnumbers and barcodes a, b, and c
>* Go to Cataloguing > Inventory
>* Enter a c b (each on its own line) into the barcode field
>* Check "Compare barcodes list to results"
>* Check "Check barcodes list for items shelved out of order"
>* Check "Export to CSV file" (at the bottom)
>* Verify the file has empty lines in the problem column
>* Apply patch
>* Repeat test, the empty lines should now read: "Shelved out of order"
>
>Note: Also fixes "problem" to "Problem" to make capitalization
>consistent. All those strings are currently not translatable,
>this will be filed separately.
>
>Co-authored-by: Mark Alexander <marka@pobox.com>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> tools/inventory.pl | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/tools/inventory.pl b/tools/inventory.pl
>index ace4e7cb7b..a2bd89e6ed 100755
>--- a/tools/inventory.pl
>+++ b/tools/inventory.pl
>@@ -405,7 +405,7 @@ if (defined $input->param('CSVexport') && $input->param('CSVexport') eq 'on'){
>         my ( $table, $column ) = split '\.', $key;
>         push @translated_keys, NormalizeString($columns->{$table}->{$column} // '');
>     }
>-    push @translated_keys, 'problem' if $uploadbarcodes;
>+    push @translated_keys, 'Problem' if $uploadbarcodes;
> 
>     $csv->combine(@translated_keys);
>     print $csv->string, "\n";
>@@ -428,6 +428,8 @@ if (defined $input->param('CSVexport') && $input->param('CSVexport') eq 'on'){
>                 $errstr .= "no barcode,";
>             } elsif( $key eq 'checkedout' ) {
>                 $errstr .= "checked out,";
>+            } elsif( $key eq 'out_of_order' ) {
>+                $errstr .= "shelved out of order,";
>             }
>         }
>         $errstr =~ s/,$//;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 22135: 84013 | 151778 | 151779 | 151955 | 155140