Bugzilla – Attachment 151956 Details for
Bug 33875
Missing closing tag a in API key management page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33875: Fix missing closing tag a in API key management page
Bug-33875-Fix-missing-closing-tag-a-in-API-key-man.patch (text/plain), 2.13 KB, created by
David Cook
on 2023-06-02 01:25:08 UTC
(
hide
)
Description:
Bug 33875: Fix missing closing tag a in API key management page
Filename:
MIME Type:
Creator:
David Cook
Created:
2023-06-02 01:25:08 UTC
Size:
2.13 KB
patch
obsolete
>From 8c0a8f6b2331ce3786a97b04116ef8a97ac91dc6 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 31 May 2023 10:58:45 -1000 >Subject: [PATCH] Bug 33875: Fix missing closing tag a in API key management > page > >In API key management page, anchor closing tag is missing in message "No keys defined for the current patron". > >This patch fixes that. >Also changes display with link on a new line. >Translatable text is on purpose surrounded by span or div. > >Test plan : >1) Enable system preference RESTOAuth2ClientCredentials >2) Go to a patron page >3) Click More > Manage API Keys >4) Look at page source HTML code >=> Check code is OK > >Signed-off-by: Sam Lau <samalau@gmail.com> >Signed-off-by: David Cook <dcook@prosentient.com.au> >--- > .../intranet-tmpl/prog/en/modules/members/apikeys.tt | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/apikeys.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/apikeys.tt >index fb6167487e..449df56785 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/apikeys.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/apikeys.tt >@@ -118,7 +118,15 @@ > </tbody> > </table> > [% ELSE %] >- <div class="dialog message">No keys defined for the current patron. <a href="#" class="toggle_element" data-element="#add-api-key" id="show-api-form"><i class="fa fa-plus"></i> Generate a new client id/secret pair</div> >+ <div class="dialog message"> >+ <div>No keys defined for the current patron.</div> >+ <div> >+ <a href="#" class="toggle_element" data-element="#add-api-key" id="show-api-form"> >+ <i class="fa fa-plus"></i> >+ <span>Generate a new client id/secret pair</span> >+ </a> >+ <div> >+ </div> > [% END %] > </div> > </main> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33875
:
151888
|
151889
|
151950
| 151956