Attachment 151967 Details for Bug 33884 – Bug 33884: Remove unused Koha::RDF code

[patch] Bug 33884: Remove unused Koha::RDF code

Bug-33884-Remove-unused-KohaRDF-code.patch (text/plain), 3.58 KB, created by Jonathan Druart on 2023-06-02 05:31:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-06-02 05:31:04 UTC

Size: 3.58 KB

patch

obsolete

>From 4eb47c74fc80a9aee5a37076c4a57aa71813a0e5 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Fri, 2 Jun 2023 02:13:01 +0000
>Subject: [PATCH] Bug 33884: Remove unused Koha::RDF code
>
>This patch removes the unused Koha::RDF module
>and its associated unit test.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> Koha/RDF.pm  | 50 --------------------------------------------------
> t/Koha/RDF.t | 33 ---------------------------------
> 2 files changed, 83 deletions(-)
> delete mode 100644 Koha/RDF.pm
> delete mode 100755 t/Koha/RDF.t
>
>diff --git a/Koha/RDF.pm b/Koha/RDF.pm
>deleted file mode 100644
>index 44a91332c50..00000000000
>--- a/Koha/RDF.pm
>+++ /dev/null
>@@ -1,50 +0,0 @@
>-package Koha::RDF;
>-
>-# Copyright 2017 Prosentient Systems
>-#
>-# This file is part of Koha.
>-#
>-# Koha is free software; you can redistribute it and/or modify it
>-# under the terms of the GNU General Public License as published by
>-# the Free Software Foundation; either version 3 of the License, or
>-# (at your option) any later version.
>-#
>-# Koha is distributed in the hope that it will be useful, but
>-# WITHOUT ANY WARRANTY; without even the implied warranty of
>-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>-# GNU General Public License for more details.
>-#
>-# You should have received a copy of the GNU General Public License
>-# along with Koha; if not, see <http://www.gnu.org/licenses>.
>-
>-use Modern::Perl;
>-use URI;
>-
>-use C4::Context;
>-
>-sub new {
>-    my ($class, $args) = @_;
>-    $args = {} unless defined $args;
>-    return bless ($args, $class);
>-}
>-
>-sub mint_uri {
>-    my ($self,$type,$number) = @_;
>-    my $new_uri;
>-    my $preference = C4::Context->preference('OPACBaseURL');
>-    if ($preference){
>-        my $uri = URI->new($preference);
>-        if ( $uri && $uri->can('scheme') && $uri->scheme && ($uri->scheme eq 'http' || $uri->scheme eq 'https') ){
>-            if ($type && $number){
>-                if ($type eq 'biblio'){
>-                    #NOTE: This is arbitrary and based on default Apache configuration at the time of writing this module
>-                    $uri->path("bib/$number");
>-                    $new_uri = $uri;
>-                }
>-            }
>-        }
>-    }
>-    return $new_uri;
>-}
>-
>-1;
>diff --git a/t/Koha/RDF.t b/t/Koha/RDF.t
>deleted file mode 100755
>index 9c164fc0a4e..00000000000
>--- a/t/Koha/RDF.t
>+++ /dev/null
>@@ -1,33 +0,0 @@
>-#!/usr/bin/perl
>-
>-# This file is part of Koha.
>-#
>-# Koha is free software; you can redistribute it and/or modify it
>-# under the terms of the GNU General Public License as published by
>-# the Free Software Foundation; either version 3 of the License, or
>-# (at your option) any later version.
>-#
>-# Koha is distributed in the hope that it will be useful, but
>-# WITHOUT ANY WARRANTY; without even the implied warranty of
>-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>-# GNU General Public License for more details.
>-#
>-# You should have received a copy of the GNU General Public License
>-# along with Koha; if not, see <http://www.gnu.org/licenses>.
>-
>-use Modern::Perl;
>-use Test::More tests => 3;
>-
>-use t::lib::Mocks;
>-
>-use_ok("Koha::RDF");
>-
>-my $rdf = Koha::RDF->new;
>-
>-t::lib::Mocks::mock_preference('OPACBaseURL', 'http://koha-community.org');
>-my $well_formed_uri = $rdf->mint_uri('biblio',1);
>-is($well_formed_uri,'http://koha-community.org/bib/1','Successfully minted a RDF URI');
>-
>-t::lib::Mocks::mock_preference('OPACBaseURL', 'koha-community.org');
>-my $malformed_uri = $rdf->mint_uri('biblio',2);
>-is($malformed_uri,undef,"Didn't mint URI due to missing URI scheme");
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 33884: 151959 | 151967 | 151968