Attachment 152004 Details for Bug 33900 – Bug 33900: Fix handling of due_digest

[patch] Bug 33900: Fix handling of due_digest

Bug-33900-Fix-handling-of-duedigest.patch (text/plain), 1.86 KB, created by Sam Lau on 2023-06-05 16:10:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Lau

Created: 2023-06-05 16:10:51 UTC

Size: 1.86 KB

patch

obsolete

>From 74595256280feb2982af26e7cb20988cd4e4622e Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Mon, 5 Jun 2023 15:38:58 +0000
>Subject: [PATCH] Bug 33900: Fix handling of due_digest
>
>Test plan, on k-t-d
>1) Go to 'my account'
>2) On 'Patron messaging preferences', click 'Edit'
>3) On the 'Item due' row, check the 'Email' and 'Digests only' checkboxes and save
>4) On the top search bar, press 'Check out' and enter '42' (koha user cardnumber)
>5) On the checkout input bar, enter a barcode e.g. 39999000001372 and press checkout
>6) Run the following query to force the due_date to be equal to 'todays' date:
>NOTE: change the YYYY-MM-DD below to whatever day it is you're running this test plan
>
>UPDATE issues SET date_due = '2023-06-05 23:59:00' where issue_id = 1;
>
>7) Run the cronjob:
>./koha/misc/cronjobs/advance_notices.pl -c --digest-per-branch
>
>8) Notice it hangs, it's stuck on an infinite loop on the 2nd while cycle after if ()
>9) Cancel the cronjob script, apply patch
>10) Run the cronjob script again (step 7), notice it finishes
>11) Access patron's notices:
>/cgi-bin/koha/members/notices.pl?borrowernumber=51
>
>Check that the 'Item due reminder' notice is there.
>
>Signed-off-by: Sam Lau <samalau@gmail.com>
>---
> misc/cronjobs/advance_notices.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl
>index b13e5cdeba..b0ccd6f1c3 100755
>--- a/misc/cronjobs/advance_notices.pl
>+++ b/misc/cronjobs/advance_notices.pl
>@@ -419,7 +419,7 @@ if ($digest_per_branch) {
>     while (my ($branchcode, $digests) = each %$due_digest) {
>         send_digests({
>             sth => $sth_digest,
>-            digests => $due_digest,
>+            digests => $digests,
>             letter_code => 'DUEDGST',
>             branchcode => $branchcode,
>             message_name => 'item_due',
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33900: 152003 | 152004 | 152159