Attachment 152030 Details for Bug 33896 – Bug 33896: Check whether index is defined before string match

[patch] Bug 33896: Check whether index is defined before string match

Bug-33896-Check-whether-index-is-defined-before-st.patch (text/plain), 1.34 KB, created by David Cook on 2023-06-06 05:40:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2023-06-06 05:40:34 UTC

Size: 1.34 KB

patch

obsolete

>From 75271e2d1bd785899294ff35847fe4a8bd526685 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Mon, 5 Jun 2023 13:08:47 +0000
>Subject: [PATCH] Bug 33896: Check whether index is defined before string match
>
>This patch checks that $indexes[$i] is defined before testing whether the string matches to remove the logged warning when searching
>
>Test plan:
>1) In the intranet, search the catalog from the top search bar
>2) Check plack-intranet-error.log
>3) There should be a warning "[WARN] Use of uninitialized value within @indexes in string eq"
>4) Apply patch
>5) restart_all and then re-try the search
>6) The warning should no longer appear
>
>Signed-off-by: David Cook <dcook@prosentient.com.au>
>---
> catalogue/search.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/catalogue/search.pl b/catalogue/search.pl
>index f3b5d7bdbc..5954bf2d67 100755
>--- a/catalogue/search.pl
>+++ b/catalogue/search.pl
>@@ -461,7 +461,7 @@ my $searcher = Koha::SearchEngine::Search->new(
> 
> # If index indicates the value is a barocode, we need to preproccess it before searching
> for ( my $i = 0; $i < @operands; $i++ ) {
>-    $operands[$i] = barcodedecode($operands[$i]) if $indexes[$i] eq 'bc';
>+    $operands[$i] = barcodedecode($operands[$i]) if (defined($indexes[$i]) && $indexes[$i] eq 'bc');
> }
> 
> ## I. BUILD THE QUERY
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33896: 151990 | 152030 | 152588