Attachment 152031 Details for Bug 33902 – Bug 33902: Move modal inside HTML body

[patch] Bug 33902: Move modal inside HTML body

Bug-33902-Move-modal-inside-HTML-body.patch (text/plain), 3.44 KB, created by David Cook on 2023-06-06 05:57:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2023-06-06 05:57:37 UTC

Size: 3.44 KB

patch

obsolete

>From 39f135b481458795e4d60ec490cffd5e1fef99c7 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Mon, 5 Jun 2023 23:00:43 +0000
>Subject: [PATCH] Bug 33902: Move modal inside HTML body
>
>To test:
>-Go Administration > Libraries and add a URL for a branch.
>-Also add some OPAC info: ( via HTML Customizations )
>-Now find a record belonging to that branch and bring up the OPAC detail page.
>-In the holdings table there should be a link under the 'Current library' column.
>-Clicking it should bring up a modal.
>-Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works.
>
>Nothing about the appearance or behavior of the page should change.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: David Cook <dcook@prosentient.com.au>
>---
> .../bootstrap/en/modules/opac-detail.tt       | 42 +++++++++----------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index 9c9da9a63d..fa05a0cc25 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -1139,6 +1139,27 @@
>     </div> 
> [% END %]
> 
>+
>+<div class="modal" id="libraryInfoModal" tabindex="-1" aria-labelledby="libraryInfoModalLabel" aria-hidden="true">
>+    <div class="modal-dialog">
>+        <div class="modal-content">
>+            <div class="modal-header">
>+                <h5 class="modal-title" id="libraryInfoModalLabel"></h5>
>+                <button type="button" class="closebtn" data-dismiss="modal" aria-label="Close">
>+                    <span aria-hidden="true">&times;</span>
>+                </button>
>+            </div>
>+            <div class="modal-body">
>+                <div id="libraryInfo"></div>
>+            </div>
>+            <div class="modal-footer">
>+                <a id="libraryInfoLink" href="" class="btn btn-primary">Visit web site</a>
>+                <button type="button" class="btn btn-secondary" data-dismiss="modal">Close</button>
>+            </div>
>+        </div> 
>+    </div> 
>+</div> 
>+
> [% INCLUDE 'opac-bottom.inc' %]
> 
> [%# End of template %]
>@@ -1398,27 +1419,6 @@
>     </table>
> [% END %][%# end of items_table block %]
> 
>-
>-<div class="modal" id="libraryInfoModal" tabindex="-1" aria-labelledby="libraryInfoModalLabel" aria-hidden="true">
>-    <div class="modal-dialog">
>-        <div class="modal-content">
>-            <div class="modal-header">
>-                <h5 class="modal-title" id="libraryInfoModalLabel"></h5>
>-                <button type="button" class="closebtn" data-dismiss="modal" aria-label="Close">
>-                    <span aria-hidden="true">&times;</span>
>-                </button>
>-            </div>
>-            <div class="modal-body">
>-                <div id="libraryInfo"></div>
>-            </div>
>-            <div class="modal-footer">
>-                <a id="libraryInfoLink" href="" class="btn btn-primary">Visit web site</a>
>-                <button type="button" class="btn btn-secondary" data-dismiss="modal">Close</button>
>-            </div>
>-        </div> 
>-    </div> 
>-</div> 
>-
> [% IF Koha.Preference('OpacCatalogConcerns') %]
>     [% INCLUDE 'modals/catalog_concern.inc' %]
> [% END %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33902: 152017 | 152022 | 152031