Attachment 152049 Details for Bug 33892 – Bug 33892: Use template wrapper for tabs: OPAC authority detail

[patch] Bug 33892: Use template wrapper for tabs: OPAC authority detail

Bug-33892-Use-template-wrapper-for-tabs-OPAC-autho.patch (text/plain), 3.22 KB, created by Lucas Gass (lukeg) on 2023-06-06 15:22:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-06-06 15:22:09 UTC

Size: 3.22 KB

patch

obsolete

>From de8fa9203b4dcfa2cb6444d301a82aeb1c8ff3a4 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 5 Jun 2023 13:06:39 +0000
>Subject: [PATCH] Bug 33892: Use template wrapper for tabs: OPAC authority
> detail
>
>This patch updates the OPAC authority detail page so that it uses
>the new WRAPPER syntax to generate tabs markup.
>
>To test, apply the patch and locate an authority record in the OPAC
>which has notes fields.
>
>When viewing the details for that record the notes should appear in a
>single "Notes" tab.
>
>Signed-off-by: Sam Lau <samalau@gmail.com>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../bootstrap/en/modules/opac-auth-detail.tt  | 23 ++++++++++---------
> 1 file changed, 12 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
>index 4711b0f1ac..c88c70a139 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
>@@ -162,22 +162,23 @@
>                             [% END # / IF MARCURLS %]
>                         [% END %]
> 
>-                        <div id="authdescriptions" class="toptabs">
>-                            <ul class="nav nav-tabs" role="tablist">
>-                                <li id="tab_descriptions" class="nav-item" role="presentation">
>-                                    <a class="nav-link active" id="descriptions-tab" data-toggle="tab" href="#descriptions" role="tab" aria-controls="descriptions" aria-selected="true" href="#descriptions">Notes</a>
>-                                </li>
>-                            </ul>
>-                            <div class="tab-content">
>-                                <div class="tab-pane active" role="tabpanel" aria-labelledby="descriptions-tab" id="descriptions">
>+                        [% WRAPPER tabs id= "authdescriptions" %]
>+                            [% WRAPPER tabs_nav %]
>+                                [% WRAPPER tab_item tabname= "tab_descriptions" bt_active= 1 %]
>+                                    <span>Notes</span>
>+                                [% END %]
>+                            [% END # /WRAPPER tabs_nav %]
>+                            [% WRAPPER tab_panels %]
>+                                [% WRAPPER tab_panel tabname="tab_descriptions" bt_active= 1 %]
>                                     <div class="content_set">
>                                         [% FOREACH note IN summary.notes %]
>                                             <p class="note auth[% note.field | html %]">[% note.note | html %]</p>
>                                         [% END %]
>                                     </div>
>-                                </div>
>-                            </div> 
>-                        </div>
>+                                [% END # /tab_panel# %]
>+                            [% END # /WRAPPER tab_panels %]
>+                        [% END # /WRAPPER tabs#authdescriptions %]
>+
>                     </div> 
>                 </div> 
>                 [% IF Koha.Preference( 'OPACAuthorIdentifiers' ) && author_identifiers.size %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33892: 151992 | 151998 | 152049