Attachment 152050 Details for Bug 33809 – Bug 33809: (follow-up) Grammar correction

[patch] Bug 33809: (follow-up) Grammar correction

Bug-33809-follow-up-Grammar-correction.patch (text/plain), 5.25 KB, created by Lucas Gass (lukeg) on 2023-06-06 15:31:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-06-06 15:31:55 UTC

Size: 5.25 KB

patch

obsolete

>From dc73b16471ce4b4d7a09a5d1e430bca597ed2214 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 1 Jun 2023 12:46:22 +0000
>Subject: [PATCH] Bug 33809: (follow-up) Grammar correction
>
>This is somewhat nitpicky but I think "Show fewer..." is more correct
>than "Show less..." for strings like "Show fewer authors."
>
>'Generally, fewer is used when the number of things is counted ("fewer
>problems") whereas less is used when the number is measured ("less
>trouble" or "less time").'
>-- https://www.merriam-webster.com/words-at-play/fewer-vs-less
>
>It's not a strict rule but to my ear it sounds more correct. The brief
>"Show less" displayed on screen seems fine because the object feels
>indeterminate: "Show less information."
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../bootstrap/en/includes/opac-facets.inc | 22 +++++++++----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>index 2b60c384b7..f1fdda3d28 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc
>@@ -100,19 +100,19 @@
> [% IF facets_loo.type_label_Location %]<a href="#" aria-label="Show more locations">Show more</a>[% END %]
> </li>
> <li class="moretoggle" style="display:none">
>- [% IF facets_loo.type_label_Authors %]<a href="#" aria-label="Show less authors">Show less</a>[% END %]
>- [% IF facets_loo.type_label_Titles %]<a href="#" aria-label="Show less titles">Show less</a>[% END %]
>- [% IF facets_loo.type_label_Topics %]<a href="#" aria-label="Show less topics">Show less</a>[% END %]
>- [% IF facets_loo.type_label_Places %]<a href="#" aria-label="Show less places">Show less</a>[% END %]
>- [% IF facets_loo.type_label_Series %]<a href="#" aria-label="Show less series">Show less</a>[% END %]
>- [% IF facets_loo.type_label_ItemTypes %]<a href="#" aria-label="Show less item types">Show less</a>[% END %]
>- [% IF facets_loo.type_label_CollectionCodes %]<a href="#" aria-label="Show less collection codes">Show less</a>[% END %]
>- [% IF facets_loo.type_label_Language %]<a href="#" aria-label="Show less languages">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_Authors %]<a href="#" aria-label="Show fewer authors">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_Titles %]<a href="#" aria-label="Show fewer titles">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_Topics %]<a href="#" aria-label="Show fewer topics">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_Places %]<a href="#" aria-label="Show fewer places">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_Series %]<a href="#" aria-label="Show fewer series">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_ItemTypes %]<a href="#" aria-label="Show fewer item types">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_CollectionCodes %]<a href="#" aria-label="Show fewer collection codes">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_Language %]<a href="#" aria-label="Show fewer languages">Show less</a>[% END %]
> [% UNLESS singleBranchMode %]
>- [% IF ( facets_loo.type_label_HomeLibrary ) %]<a href="#" aria-label="Show less home libraries">Show less</a>[% END %]
>- [% IF ( facets_loo.type_label_HoldingLibrary ) %]<a href="#" aria-label="Show less holding libraries">Show less</a>[% END %]
>+ [% IF ( facets_loo.type_label_HomeLibrary ) %]<a href="#" aria-label="Show fewer home libraries">Show less</a>[% END %]
>+ [% IF ( facets_loo.type_label_HoldingLibrary ) %]<a href="#" aria-label="Show fewer holding libraries">Show less</a>[% END %]
> [% END %]
>- [% IF facets_loo.type_label_Location %]<a href="#" aria-label="Show less locations">Show less</a>[% END %]
>+ [% IF facets_loo.type_label_Location %]<a href="#" aria-label="Show fewer locations">Show less</a>[% END %]
> </li>
> [% END %]
> </ul>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33809: 151568 | 151569 | 151576 | 151606 | 151607 | 151925 | 152050 | 153121 | 157986 | 157987 | 157988 | 157989