Attachment 15208 Details for Bug 9582 – Bug 9582: Remove unused code from members/pay.pl

[patch] Bug 9582: Remove unused code from members/pay.pl

Bug-9582-Remove-unused-code-from-memberspaypl.patch (text/plain), 3.05 KB, created by Jared Camins-Esakov on 2013-02-10 15:46:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jared Camins-Esakov

Created: 2013-02-10 15:46:22 UTC

Size: 3.05 KB

patch

obsolete

>From 7838220e7a3a1c4f4eebc249b3959e1c952f93ab Mon Sep 17 00:00:00 2001
>From: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Date: Sun, 10 Feb 2013 10:39:20 -0500
>Subject: [PATCH] Bug 9582: Remove unused code from members/pay.pl
>
>The subroutines writeoff() and get_writeoff_sth() (and the two package
>variables $writeoff_sth and $add_writeoff_sth) defined in members/pay.pl
>are not used at all.
>
>To test:
>1) View members/pay.pl by looking at the record of a patron who has
>   at least seven fines/fees and clicking the "Pay fines" tab after
>   clicking the "Fines" tab on the left side
>2) Write off a single item in the table on members/pay.pl using the
>   button labelled "Write off"
>3) Pay a single fine by clicking the "Pay" button
>4) Pay a portion of a fine by selecting a checkbox on one of the lines
>   in the table and clicking the "Pay amount" button
>5) Select two lines in the table and click the "Pay selected" button
>6) Write off all remaining fines
>
>If all your actions show up in the table on the Account tab, this patch
>works.
>---
> members/pay.pl |   40 ----------------------------------------
> 1 file changed, 40 deletions(-)
>
>diff --git a/members/pay.pl b/members/pay.pl
>index a08e372..4b918ae 100755
>--- a/members/pay.pl
>+++ b/members/pay.pl
>@@ -42,8 +42,6 @@ use C4::Branch;
> use C4::Members::Attributes qw(GetBorrowerAttributes);
> 
> our $input = CGI->new;
>-our $writeoff_sth;
>-our $add_writeoff_sth;
> 
> our ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>     {   template_name   => 'members/pay.tmpl',
>@@ -108,24 +106,6 @@ add_accounts_to_template();
> 
> output_html_with_http_headers $input, $cookie, $template->output;
> 
>-sub writeoff {
>-    my ( $accountlines_id, $itemnum, $accounttype, $amount ) = @_;
>-    my $manager_id = 0;
>-    $manager_id = C4::Context->userenv->{'number'} if C4::Context->userenv;
>-
>-    # if no item is attached to fine, make sure to store it as a NULL
>-    $itemnum ||= undef;
>-    get_writeoff_sth();
>-    $writeoff_sth->execute( $accountlines_id );
>-
>-    my $acct = getnextacctno($borrowernumber);
>-    $add_writeoff_sth->execute( $borrowernumber, $acct, $itemnum, $amount, $manager_id );
>-
>-    UpdateStats( $branch, 'writeoff', $amount, q{}, q{}, q{}, $borrowernumber );
>-
>-    return;
>-}
>-
> sub add_accounts_to_template {
> 
>     my ( $total, undef, undef ) = GetMemberAccountRecords($borrowernumber);
>@@ -271,23 +251,3 @@ sub payselected {
>     print $input->redirect($redirect);
>     return;
> }
>-
>-sub get_writeoff_sth {
>-
>-    # lets prepare these statement handles only once
>-    if ($writeoff_sth) {
>-        return;
>-    } else {
>-        my $dbh = C4::Context->dbh;
>-
>-        # Do we need to validate accounttype
>-        my $sql = 'Update accountlines set amountoutstanding=0 '
>-          . 'WHERE accountlines_id=?';
>-        $writeoff_sth = $dbh->prepare($sql);
>-        my $insert =
>-q{insert into accountlines (borrowernumber,accountno,itemnumber,date,amount,description,accounttype,manager_id)}
>-          . q{values (?,?,?,now(),?,'Writeoff','W',?)};
>-        $add_writeoff_sth = $dbh->prepare($insert);
>-    }
>-    return;
>-}
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9582: 15208 | 15352 | 15548