Bugzilla – Attachment 15215 Details for
Bug 9585
Fix spelling mistake in default tab conditional for opac-detail
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9585 - Fix spelling mistake in default tab conditional for opac-detail
0001-Bug-9585-Fix-spelling-mistake-in-default-tab-conditi.patch (text/plain), 1.51 KB, created by
David Cook
on 2013-02-11 05:30:51 UTC
(
hide
)
Description:
Bug 9585 - Fix spelling mistake in default tab conditional for opac-detail
Filename:
MIME Type:
Creator:
David Cook
Created:
2013-02-11 05:30:51 UTC
Size:
1.51 KB
patch
obsolete
>From ec5a185897a800ad1828f327bb1504ddecce524c Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 11 Feb 2013 16:24:20 +1100 >Subject: [PATCH] Bug 9585 - Fix spelling mistake in default tab conditional > for opac-detail > >There is just a small typo where one of the results of a conditional is "subscription" rather than "subscriptions". > >If this comes up, the correct tab (subscriptions) will not be chosen. > >I'm not sure what will happen...it'll probably just have the "holdings", "subscriptions", and "serial collection" tabs all default to closed with none of them being open. > >--- > >Test Plan: > >The easiest way to test is just to double-check the other strings in the conditional which say "subscriptions" rather than "subscription". > >You can also look at opac-detail.tt where the param is shown, and note that there is no condition for "subscription" - just "subscriptions". > >Any tests other than that would be overly complex for such a trivial patch. >--- > opac/opac-detail.pl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 94edb35..cc22acc 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -990,7 +990,7 @@ my $defaulttab = > $subscriptionsnumber > ? 'subscriptions' : > @serialcollections > 0 >- ? 'serialcollection' : 'subscription'; >+ ? 'serialcollection' : 'subscriptions'; > $template->param('defaulttab' => $defaulttab); > > if (C4::Context->preference('OPACLocalCoverImages') == 1) { >-- >1.7.7.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9585
:
15215
|
15261
|
15274