Attachment 15216 Details for Bug 9586 – Bug 9586 - Remove $ENV{DEBUG} info from Member Template

[patch] Bug 9586 - Remove $ENV{DEBUG} info from Member Template

0001-Bug-9586-Remove-ENV-DEBUG-info-from-Member-Template.patch (text/plain), 2.76 KB, created by David Cook on 2013-02-11 05:50:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2013-02-11 05:50:57 UTC

Size: 2.76 KB

patch

obsolete

>From a9cecbe4ae1f619334f680e6d3e59bf2b6abefe7 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Mon, 11 Feb 2013 16:42:56 +1100
>Subject: [PATCH] Bug 9586 - Remove $ENV{DEBUG} info from Member Template
>
>Currently, if $ENV{DEBUG} is set (for example to 1), the debug level will be printed on the Add/Edit Patron pages (memberentrygen.tt) in the form of: "Debug is on (level 1)".
>
>While many if not most folks might not set $ENV{DEBUG} on a production system, there is no reason to have this information printing on the member template(s).
>
>No where else in Koha is there a template that prints $ENV{DEBUG} information, with the exception of calendar.inc, although that doesn't activate until at least debug level 2 or 5, so it might be worth holding on to. It is certainly more complicated than simply printing the debug level. I don't do development on the calendars, so I'm not going to address that one.
>
>---
>
>Test Plan:
>
>Before applying patch...
>
>1) Modify koha-httpd.conf, and add the following line, in the virtualhost (if it does not already exist):
>
>SetEnv DEBUG 1
>
>2) Restart/reload Apache
>
>3) Go to Add a New Patron
>4) Note that the message "Debug is on (level 1)" appears at the top of the page above the patron entry form
>
>After applying patch...
>
>5) Reload the patron add/edit page
>6) Note that the message "Debug is on (level 1)" no longer appears
>
>7) Change your koha-httpd.conf settings back as necessary...
>---
> .../prog/en/modules/members/memberentrygen.tt      |    5 -----
> members/memberentry.pl                             |    1 -
> 2 files changed, 0 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index edabba0..68d6a30 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -141,11 +141,6 @@
> 			</div>
> 	[% END %]
> 
>-	[% IF ( debug ) %]
>-		<div id="debug">
>-				<div>Debug is on (level [% debug %])</div>
>-		</div>
>-	[% END %]
> 	[% IF ( nok ) %]
> 		<div class="dialog alert">
> 			<p>The following fields are wrong. Please fix them.</p>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index f6d3e5e..7fc27c0 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -699,7 +699,6 @@ $debug and warn "memberentry step: $step";
> $template->param(%data);
> $template->param( "step_$step"  => 1) if $step;	# associate with step to know where u are
> $template->param(  step  => $step   ) if $step;	# associate with step to know where u are
>-$template->param( debug  => $debug  ) if $debug;
> 
> $template->param(
>   BorrowerMandatoryField => C4::Context->preference("BorrowerMandatoryField"),#field to test with javascript
>-- 
>1.7.7.4
>

Actions: View | Diff | Splinter Review

Attachments on bug 9586: 15216 | 15351 | 15894