Bugzilla – Attachment 152179 Details for
Bug 33946
biblio-title.inc should not add a link if biblio does not exist
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33946: Resync opac/intranet includes
Bug-33946-Resync-opacintranet-includes.patch (text/plain), 2.58 KB, created by
Martin Renvoize (ashimema)
on 2023-06-08 12:21:15 UTC
(
hide
)
Description:
Bug 33946: Resync opac/intranet includes
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-06-08 12:21:15 UTC
Size:
2.58 KB
patch
obsolete
>From 371f37f6a137fb52e0c9ab71404986d7ee3a3266 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 8 Jun 2023 13:19:07 +0100 >Subject: [PATCH] Bug 33946: Resync opac/intranet includes > >This patch resyncs the whitespace chomping in the opac include to match >that in the intranet include so aid in diffing between the two. > >No changes should be visible in the UI but there may be cleaner markup >as a result. >--- > .../bootstrap/en/includes/biblio-title.inc | 36 +++++++++---------- > 1 file changed, 18 insertions(+), 18 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/biblio-title.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/biblio-title.inc >index d3bbf53917..7201dd2df8 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/biblio-title.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/biblio-title.inc >@@ -1,7 +1,7 @@ > [%- IF link && ! biblio %][% link = 0 %][% END %] >-[% IF ( link ) %] >- <a href="[% PROCESS biblio_a_href biblionumber => biblio.biblionumber %]" class="title"> >-[% END %] >+[%- IF ( link ) -%] >+ <a href="[%- PROCESS biblio_a_href biblionumber => biblio.biblionumber -%]" class="title"> >+[%- END -%] > > [%- IF !biblio -%] > No bibliographic record >@@ -10,22 +10,22 @@ > [%- ELSE -%] > <span class="biblio-title">[% biblio.title | html %]</span> > [%- END -%] >-[% FOREACH subtitle IN biblio.subtitle.split(' \| ') %][% IF Koha.Preference('marcflavour')=='UNIMARC' %],[% END %] >- <span class="subtitle">[% subtitle | html %]</span> >-[% END %] >-[% part_numbers = biblio.part_number.split(' \\| ') %] >-[% part_names = biblio.part_name.split(' \\| ') %] >-[% i = 0 %] >-[% WHILE ( part_numbers.$i.defined || part_names.$i.defined ) %] >- [% IF ( part_numbers.$i.defined ) %] >+[%- FOREACH subtitle IN biblio.subtitle.split(' \\| ') -%][%- IF Koha.Preference('marcflavour')=='UNIMARC' -%],[%- END -%] >+ <span class="subtitle">[%- subtitle | html -%]</span> >+[%- END -%] >+[%- part_numbers = biblio.part_number.split(' \\| ') -%] >+[%- part_names = biblio.part_name.split(' \\| ') -%] >+[%- i = 0 -%] >+[%- WHILE ( part_numbers.$i.defined || part_names.$i.defined ) -%] >+ [%- IF ( part_numbers.$i.defined ) -%] > <span class="part-number">[% part_numbers.$i | html %]</span> >- [% END %] >- [% IF ( part_names.$i.defined ) %] >+ [%- END -%] >+ [%- IF ( part_names.$i.defined ) -%] > <span class="part-name">[% part_names.$i | html %]</span> >- [% END %] >- [% i = i + 1 %] >-[% END %] >+ [%- END -%] >+ [%- i = i + 1 -%] >+[%- END -%] > >-[% IF ( link ) %] >+[%- IF ( link ) -%] > </a> >-[% END %] >+[%- END -%] >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33946
:
152145
|
152178
|
152179
|
153297
|
153298
|
153299