Attachment 152274 Details for Bug 33966 – Bug 33966: (bug 23824 follow-up) Fix submit buttons for translated templates

[patch] Bug 33966: (bug 23824 follow-up) Fix submit buttons for translated templates

Bug-33966-bug-23824-follow-up-Fix-submit-buttons-f.patch (text/plain), 2.58 KB, created by Andrii Nugged on 2023-06-11 13:42:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrii Nugged

Created: 2023-06-11 13:42:59 UTC

Size: 2.58 KB

patch

obsolete

>From 5c73446db9d064c62602306e8c9640796c54af4c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 9 Jun 2023 15:35:41 +0200
>Subject: [PATCH] Bug 33966: (bug 23824 follow-up) Fix submit buttons for
> translated templates
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Andrii Nugged <nugged@gmail.com>
>---
> .../prog/en/modules/reports/guided_reports_start.tt           | 4 ++--
> reports/guided_reports.pl                                     | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index cbc7326deb..62df2bc7e2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -1360,8 +1360,8 @@
>                         </fieldset>
> 
>                         <fieldset class="action">
>-                            <input type="submit" name="phase" class="btn btn-primary" value="Update SQL" />
>-                            <input type="submit" name="phase" class="btn btn-primary" value="Update and run SQL" />
>+                            <button class="btn btn-primary" type="submit" name="phase" value="update_sql">Update SQL</button>
>+                            <button class="btn btn-default" type="submit" name="phase" value="update_and_run_sql">Update and run SQL</button>
>                             <a href="/cgi-bin/koha/reports/guided_reports.pl?phase=Use%20saved" class="cancel">Cancel</a>
>                         </fieldset>
>                     </form>
>diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
>index fb51ab27fa..46792bf88c 100755
>--- a/reports/guided_reports.pl
>+++ b/reports/guided_reports.pl
>@@ -209,7 +209,7 @@ elsif ( $phase eq 'Edit SQL'){
>     );
> }
> 
>-elsif ( $phase eq 'Update SQL' || $phase eq 'Update and run SQL' ){
>+elsif ( $phase eq 'update_sql' || $phase eq 'update_and_run_sql' ){
>     my $id         = $input->param('id');
>     my $sql        = $input->param('sql');
>     my $reportname = $input->param('reportname');
>@@ -301,7 +301,7 @@ elsif ( $phase eq 'Update SQL' || $phase eq 'Update and run SQL' ){
>                 cache_expiry_units => $cache_expiry_units,
>             );
>         }
>-        if ( $phase eq 'Update and run SQL' ) {
>+        if ( $phase eq 'update_and_run_sql' ) {
>             print $input->redirect("/cgi-bin/koha/reports/guided_reports.pl?reports=$id&phase=Run%20this%20report");
>         }
>     }
>-- 
>2.41.0

Actions: View | Diff | Splinter Review

Attachments on bug 33966: 152248 | 152267 | 152274