Attachment 152311 Details for Bug 33990 – Bug 33990: Correctly access subtitle for Recalls awaiting pickup report

[patch] Bug 33990: Correctly access subtitle for Recalls awaiting pickup report

Bug-33990-Correctly-access-subtitle-for-Recalls-aw.patch (text/plain), 2.76 KB, created by Sam Lau on 2023-06-13 16:24:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Lau

Created: 2023-06-13 16:24:54 UTC

Size: 2.76 KB

patch

obsolete

>From d7a05486fdb78d062b4c466ac4f20ac6e6438a4a Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Tue, 13 Jun 2023 04:04:26 +0000
>Subject: [PATCH] Bug 33990: Correctly access subtitle for Recalls awaiting
> pickup report
>
>This patch fixes how the bibliographic record's subtitle is fetched to prevent the page from exploding when viewing the recalls awaiting pickup for a problematic number of days.
>
>To test:
>
>1. Enable UseRecalls syspref and set the relevant circulation and fines rules to configure recalls
>2. Set the RecallsMaxPickUpDelay to 1 day
>3. Check out Item A to Patron A
>4. Log into the OPAC as Patron B
>5. Search for Item A and place a recall
>6. Log back into the staff interface and check in Item A
>7. Confirm the recall as waiting for Patron B
>8. Go to Circulation -> Recalls awaiting pickup
>9. Confirm your recall exists under the 'Recalls waiting' tab
>10. Change the waiting_date in the database for this recall to a few days ago so we would expect to see it under the 'Recalls waiting over 1 days' tab
>
>sudo koha-mysql INSTANCE
>select * from recalls; # to get the recall_id
>update recalls set waiting_date = "2023-06-10 03:54:21" where recall_id = X;
>
>11. Refresh the Circulation -> Recalls awaiting pickup page
>12. Confirm the page blows up and there is an error
>
>13. Apply the patch and refresh the page
>
>14. Confirm the page loads successfully and your recall is showing as expected under the 'Recalls waiting over 1 days' tab
>15. Confirm the subtitle (probably in 245$b) shows as expected
>
>Sponsored-by: Auckland University of Technology
>Signed-off-by: Sam Lau <samalau@gmail.com>
>---
> .../intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt    | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt
>index a0686c1fa4..1f424f5f80 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt
>@@ -106,7 +106,7 @@
>                                             <td class="recall-title">
>                                                 <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% recall.biblio_id | uri %]">
>                                                     [% recall.biblio.title | html %]
>-                                                    [% FOREACH s IN recall.biblio.subtitles %]
>+                                                    [% FOREACH s IN recall.biblio.subtitle %]
>                                                         [% s | html %]
>                                                     [% END %]
>                                                     [% recall.item.enumchron | html %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33990: 152286 | 152311 | 152602