Attachment 152542 Details for Bug 34072 – Bug 34072: Remove float/clear from froms.scss

[patch] Bug 34072: Remove float/clear from froms.scss

Bug-34072-Remove-floatclear-from-fromsscss.patch (text/plain), 1.39 KB, created by ByWater Sandboxes on 2023-06-21 20:43:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2023-06-21 20:43:09 UTC

Size: 1.39 KB

patch

obsolete

>From d927a0882eab55e8d33eb6b5543388dd9928aea7 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Tue, 20 Jun 2023 22:19:01 +0000
>Subject: [PATCH] Bug 34072: Remove float/clear from froms.scss
>
>To test:
>- go to /cgi-bin/koha/circ/view_holdsqueue.pl
>- inspect something within the page to open the dev tools
>- press ctrl-shift-m to show the device toolbar
>- use the device toolbar to reduce the resolution of your window
>- observe that the search controls are lost at smaller resolutions
>- Apply patch, regerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ), clear browser cache
>- Try again, you should now see the search controls
>- Since this patch changes forms.scss try some other forms in Koha at different screen sizes to make sure they still look correct
>
>Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
>---
> koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss
>index 99f8adfbca..9c6f60394b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss
>@@ -19,8 +19,6 @@ fieldset {
>     }
> 
>     &.rows {
>-        clear: left;
>-        float: left;
>         margin: .9em 0 0;
>         padding: 1rem;
>         width: 100%;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34072: 152495 | 152542 | 153227