Bugzilla – Attachment 152565 Details for
Bug 33117
Patron checkout search not working if searching with second surname
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33117: (follow-up) Make preference options match existing codebase
Bug-33117-follow-up-Make-preference-options-match-.patch (text/plain), 4.19 KB, created by
Martin Renvoize (ashimema)
on 2023-06-22 13:44:21 UTC
(
hide
)
Description:
Bug 33117: (follow-up) Make preference options match existing codebase
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2023-06-22 13:44:21 UTC
Size:
4.19 KB
patch
obsolete
>From a34a9d5e2d34fc5dbdc10e643764ff030268aba5 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 22 Jun 2023 14:42:35 +0100 >Subject: [PATCH] Bug 33117: (follow-up) Make preference options match existing > codebase > >We pass a searchtype around sometimes, this is either 'start_with' or >'contain'.. we should match the preference options (i.e. drop the 's') > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > installer/data/mysql/atomicupdate/bug_33117.pl | 2 +- > installer/data/mysql/mandatory/sysprefs.sql | 2 +- > koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_33117.pl b/installer/data/mysql/atomicupdate/bug_33117.pl >index 4d1eac19c5..27c7905668 100644 >--- a/installer/data/mysql/atomicupdate/bug_33117.pl >+++ b/installer/data/mysql/atomicupdate/bug_33117.pl >@@ -9,7 +9,7 @@ return { > > $dbh->do(q{ > INSERT INTO systempreferences (`variable`,`value`,`explanation`,`options`,`type`) >- VALUES ('DefaultPatronSearchMethod','starts_with','Allows staff to set a default method when searching for patrons with autocomplete','starts_with|contains','Choice'); >+ VALUES ('DefaultPatronSearchMethod','start_with','Allows staff to set a default method when searching for patrons with autocomplete','start_with|contain','Choice'); > }); > > say $out "Added new system preference 'DefaultPatronSearchMethod'"; >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index 38a756f817..af1bccaa3b 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -184,7 +184,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('DefaultLongOverdueDays', '', NULL, "Set the LOST value of an item when the item has been overdue for more than n days.", 'integer'), > ('DefaultLongOverdueLostValue', '', NULL, "Set the LOST value of an item to n when the item has been overdue for more than defaultlongoverduedays days.", 'integer'), > ('DefaultPatronSearchFields', 'firstname,middle_name,surname,othernames,cardnumber,userid',NULL,'Comma separated list defining the default fields to be used during a patron search using the "standard" option. If empty Koha will default to "firstname,surname,othernames,cardnumber,userid". Additional fields added to this preference will be added as search options in the dropdown menu on the patron search page.','free'), >-('DefaultPatronSearchMethod','starts_with','Choose which search method to use by default when searching with PatronAutoComplete','starts_with|contains','Choice'), >+('DefaultPatronSearchMethod','start_with','Choose which search method to use by default when searching with PatronAutoComplete','start_with|contain','Choice'), > ('DefaultSaveRecordFileID','biblionumber','biblionumber|controlnumber','Defines whether the advanced cataloging editor will use the bibliographic record number or control number field to populate the name of the save file','Choice'), > ('defaultSortField','relevance','relevance|popularity|call_number|pubdate|acqdate|title|author','Specify the default field used for sorting','Choice'), > ('defaultSortOrder','dsc','asc|dsc|az|za','Specify the default sort order','Choice'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc >index a5159b0150..0088a7e3dc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc >@@ -71,7 +71,7 @@ > > <script> > var defaultPatronSearchFields = "[% Koha.Preference('DefaultPatronSearchFields') || 'firstname,middle_name,surname,othernames,cardnumber,userid' | html %]"; >- var defaultPatronSearchMethod = "[% Koha.Preference('DefaultPatronSearchMethod') || 'contains' | html %]"; >+ var defaultPatronSearchMethod = "[% Koha.Preference('DefaultPatronSearchMethod') || 'contain' | html %]"; > var loggedInLibrary = '[% Branches.GetLoggedInBranchcode | html %]'; > var singleBranchMode = '[% singleBranchMode | html %]'; > </script> >-- >2.41.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33117
:
148018
|
148027
|
148095
|
148131
|
148138
|
148278
|
148279
|
148280
|
148282
|
148336
|
148383
|
148384
|
148443
|
148445
|
148467
|
148481
|
150781
|
150896
|
150897
|
150898
|
151090
|
151091
|
151302
|
151314
|
151317
|
151769
|
151771
|
151825
|
151845
|
152549
|
152552
|
152554
|
152555
|
152556
|
152562
|
152563
|
152564
|
152565
|
154309