Bugzilla – Attachment 152574 Details for
Bug 34086
On detail.tt if item.permanent_location is NULL no shelving location will show
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34086: Show location on detail page when there is no permenant location
Bug-34086-Show-location-on-detail-page-when-there-.patch (text/plain), 2.29 KB, created by
Sam Lau
on 2023-06-22 16:35:35 UTC
(
hide
)
Description:
Bug 34086: Show location on detail page when there is no permenant location
Filename:
MIME Type:
Creator:
Sam Lau
Created:
2023-06-22 16:35:35 UTC
Size:
2.29 KB
patch
obsolete
>From 771836aa707374ec9a07522c1510421edaa9006c Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 21 Jun 2023 19:21:05 +0000 >Subject: [PATCH] Bug 34086: Show location on detail page when there is no > permenant location > >To test: >1. Have some items without a permanent location. >2. Go to the staff detail page. >3. In the 'Home library' column notice the span .shelvingloc is empty. >4. Add a permanent location, now the shelvingloc is populated >5. Apply patch >6. The location should now show even when there is no permenant location. > >Signed-off-by: Sam Lau <samalau@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index d4ead1659f..402e3c17cc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -420,10 +420,10 @@ > [%# If permanent location is defined, show description or code and %] > [%# display current location in parentheses. If not, display current location. %] > [%# Note that permanent location is a code, and location may be an authval. %] >- [% IF item.permanent_location %] >+ [% SET item_location = AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => item.location ) %] >+ [% IF item.permanent_location %] > [% SET permloc_authval = AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => item.permanent_location ) %] > [% permloc_authval | html %] >- [% SET item_location = AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => item.location ) %] > [% IF item_location AND item_location != permloc_authval AND item.location != item.permanent_location %] > ([% item_location | html %]) > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34086
:
152538
|
152574
|
153215