Attachment 152592 Details for Bug 34052 – Bug 34052: Use root relative URL for subscription-detail.pl

[patch] Bug 34052: Use root relative URL for subscription-detail.pl

Bug-34052-Use-root-relative-URL-for-subscription-d.patch (text/plain), 2.99 KB, created by Katrin Fischer on 2023-06-22 20:33:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-06-22 20:33:54 UTC

Size: 2.99 KB

patch

obsolete

>From e9a8c623fdd5cadbeff6d5accf8cb6ade3d84ddc Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Mon, 19 Jun 2023 04:28:53 +0000
>Subject: [PATCH] Bug 34052: Use root relative URL for subscription-detail.pl
>
>This patch replaces a same directory relative URL with a root
>relative URL, so that the navigation to subscription-detail.pl
>works correctly after deleting a serial.
>
>To test:
>0. Apply patch
>1. Go to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl
>2. Click "New subscription"
>3. Click "Search for a vendor"
>4. Click "OK"
>5. Click "Choose"
>6. Click "Search for record"
>7. Type "e" into "Keyword:" box
>8. Click "Search"
>9. Click "Choose" on top result
>10. Click "Next"
>11. Fill in "Serials planning" however you like, and click
>"Test prediction pattern"
>12. Click "Save subscription"
>13. Click "Serial collection" in left nav menu
>14. Click "Delete selected issues"
>15. Click "Yes, delete"
>16. Click the link under the "Subscription num." table column
>17. Note that you're taken to the subscription detail page
>
>Signed-off-by: Sam Lau <samalau@gmail.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../prog/en/modules/serials/serials-collection.tt             | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
>index f8252d48be..52a4e3be50 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
>@@ -49,7 +49,7 @@
>                 [% IF ( delete ) %]
>                     <div class="dialog alert">
>                         <h3>You are about to delete [% serialnumber | html %] serial(s). Do you want to continue?</h3>
>-                        <form action="/cgi-bin/koha/serials/serials-collection.pl/#">
>+                        <form action="/cgi-bin/koha/serials/serials-collection.pl">
>                             [% IF countitems > 0 %]
>                                 <h5>Number of items available: [% countitems | html %]</h5>
>                                 <p>
>@@ -95,7 +95,7 @@
>                         </tr>
>                         [% FOREACH subscription IN subscriptions %]
>                             <tr>
>-                                <td><a href="subscription-detail.pl?subscriptionid=[% subscription.subscriptionid | uri %]"># [% subscription.subscriptionid | html %]</a> </td>
>+                                <td><a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% subscription.subscriptionid | uri %]"># [% subscription.subscriptionid | html %]</a> </td>
>                                 <td>[% subscription.frequency.description | html %]</td>
>                                 <td>[% subscription.numberpattern.label | html %]</td>
>                                 <td>[% IF subscription.branchcode %][% Branches.GetName( subscription.branchcode ) | html %][% END %]</td>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34052: 152459 | 152493 | 152591 | 152592