Attachment 152604 Details for Bug 34106 – Bug 34106: Retain searchtype parameter in member-search-box

[patch] Bug 34106: Retain searchtype parameter in member-search-box

Bug-34106-Retain-searchtype-parameter-in-member-se.patch (text/plain), 2.11 KB, created by Lucas Gass (lukeg) on 2023-06-22 22:01:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-06-22 22:01:46 UTC

Size: 2.11 KB

patch

obsolete

>From 0ce30aae00a4bdd581ac3b4bf902bc429ec12aba Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 22 Jun 2023 21:59:35 +0000
>Subject: [PATCH] Bug 34106: Retain searchtype parameter in member-search-box
>
>To test:
>
>1. In the main search header switch to 'Search patrons'. Bring up the dropdown and look at 'Search type:'.
>2. It defaults to 'Starts with'.
>3. Go to '/cgi-bin/koha/members/members-home.pl' and look at the 'Search type:' on the left side.
>4. It defaults to 'Contains'
>5. Do a patron search from both these places, setting the 'Search type' to contains.
>6. The search bar in the header always resets to 'Starts with'
>7. Apply patch
>8. Try everything again. By default both places should default to contain.
>9. If you change the 'Search type' the search in the main header should always retain that value.
>---
> .../intranet-tmpl/prog/en/includes/member-search-box.inc      | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/member-search-box.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/member-search-box.inc
>index 05fcdd2537..09d3a4e3a0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/member-search-box.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/member-search-box.inc
>@@ -37,11 +37,11 @@
>                     <label for="searchtype" class="control-label">Search type</label>
>                     <select name="searchtype" id="searchtype" class="form-control">
>                         [% IF searchtype == 'start_with' %]
>-                            <option value='start_with'>Starts with</option>
>+                            <option value='start_with' selected='selected'>Starts with</option>
>                             <option value='contain'>Contains</option>
>                         [% ELSE %]
>                             <option value='start_with'>Starts with</option>
>-                            <option value='contain'>Contains</option>
>+                            <option value='contain' selected='selected'>Contains</option>
>                         [% END %]
>                     </select>
>                 </div>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34106: 152604 | 152641 | 152743 | 152748 | 152785 | 152786