Attachment 152610 Details for Bug 33578 – Bug 33578: Fix patron restriction types edition

[patch] Bug 33578: Fix patron restriction types edition

Bug-33578-Fix-patron-restriction-types-edition.patch (text/plain), 1.33 KB, created by Marcel de Rooy on 2023-06-23 06:27:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2023-06-23 06:27:56 UTC

Size: 1.33 KB

patch

obsolete

>From 34deade6cb49cc9cb7caac726494f75a345570ef Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 10 May 2023 11:21:19 +0200
>Subject: [PATCH] Bug 33578: Fix patron restriction types edition
>Content-Type: text/plain; charset=utf-8
>
>When editing an existing patron restriction type you'll always get an error on saving:
>
>Label is already in use
>
>To test:
>* Activate use of patron restriction types
>* Edit any of the system types
>* Create new ones
>
>Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt
>index 2c41652fb6..c29b3726b4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt
>@@ -211,6 +211,7 @@
>         var MSG_DUPLICATE_DISPLAY_TEXT = _("Restriction type label is already in use");
>         var existing = {
>         [% FOREACH ex IN existing %]
>+            [% NEXT IF ex.code == restriction.code %]
>             [% ex.code | $raw %]: '[% ex.display_text | $raw %]',
>         [% END %]
>         };
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33578: 150957 | 150976 | 151478 | 151479 | 152610 | 152611