Attachment 152633 Details for Bug 34075 – Bug 34075: (follow-up) Fixes for QA tool errors

[patch] Bug 34075: (follow-up) Fixes for QA tool errors

Bug-34075-follow-up-Fixes-for-QA-tool-errors.patch (text/plain), 2.13 KB, created by Owen Leonard on 2023-06-23 13:05:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-06-23 13:05:52 UTC

Size: 2.13 KB

patch

obsolete

>From cf62b931cb5bc00e3e574a7e519274cb1eda87f8 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 23 Jun 2023 13:03:40 +0000
>Subject: [PATCH] Bug 34075: (follow-up) Fixes for QA tool errors
>
>- Added missing filter to template variable
>- Correct spelling in atomicupdate
>---
> installer/data/mysql/atomicupdate/bug_34075.pl                | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_34075.pl b/installer/data/mysql/atomicupdate/bug_34075.pl
>index fe83258dfe..a573b74f72 100755
>--- a/installer/data/mysql/atomicupdate/bug_34075.pl
>+++ b/installer/data/mysql/atomicupdate/bug_34075.pl
>@@ -8,7 +8,7 @@ return {
>         my ($dbh, $out) = @$args{qw(dbh out)};
>         $dbh->do(q{
>             INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES
>-            ('DefaultAuthorityTab','0','0|1|2|3|4|5|6|7|8|9','Default tab to shwo when displaying authorities','Choice')
>+            ('DefaultAuthorityTab','0','0|1|2|3|4|5|6|7|8|9','Default tab to show when displaying authorities','Choice')
>         });
>         say $out "Added new system preference 'DefaultAuthorityTab'";
>     },
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
>index d5ad806a28..1afe9c321e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
>@@ -135,7 +135,7 @@
>             if( $("#authoritiestabs .tab-pane.active").length < 1 ){
>                 [% SET DefaultAuthorityTab = Koha.Preference('DefaultAuthorityTab') %]
>                 [% IF DefaultAuthorityTab %]
>-                    let default_tab = "#tab" + [% DefaultAuthorityTab %] + "XX-tab";
>+                    let default_tab = "#tab" + [% DefaultAuthorityTab | html %] + "XX-tab";
>                     let tab_object = $("#authoritiestabs "+default_tab)
>                     if( tab_object.length > 0 ){
>                         tab_object.tab("show");
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34075: 152518 | 152582 | 152584 | 152633 | 153625 | 153626 | 153627